WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] HT support on VMX broken

To: "Leendert van Doorn" <leendert@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] HT support on VMX broken
From: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Date: Wed, 5 Jan 2005 13:55:09 -0800
Cc: <m+Ian.Pratt@xxxxxxxxxxxx>, "Andrew Morton" <akpm@xxxxxxxx>
Delivery-date: Wed, 05 Jan 2005 21:56:59 +0000
Envelope-to: xen+James.Bulpin@xxxxxxxxxxxx
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
Thread-index: AcTzafGAuY/Nyvc/R6umSfQpzUCKqgABJpjA
Thread-topic: [Xen-devel] HT support on VMX broken
>From: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx [mailto:xen-devel-
>admin@xxxxxxxxxxxxxxxxxxxxx] On Behalf Of Leendert van Doorn
>Sent: Wednesday, January 05, 2005 11:42 AM
>To: xen-devel@xxxxxxxxxxxxxxxxxxxxx
>Cc: m+Ian.Pratt@xxxxxxxxxxxx
>Subject: [Xen-devel] HT support on VMX broken
>
>
>Hyperthreading on VMX is broken in the xeno-unstable.bk tree. The diff
>below fixes this.
The patch looks reasonable. HT makes the case worse, but that's a
generic bug. Looks like this driver was incorporated into Xen after VMX
support was added. We need to fix the mtrr driver in Linux as well.
Copying Andrew.

Thanks,
Jun

>
>It turns out that the mtrr code clears too many bits, some of them
cause
>Xen to crash. Being a bit more precise fixes the problem.
>
>       Leendert
>
>--- generic.c.orig     2005-01-03 23:44:18.000000000 -0500
>+++ generic.c  2005-01-05 14:57:16.840893000 -0500
>@@ -250,7 +250,7 @@
>       /*  Save value of CR4 and clear Page Global Enable (bit 7)  */
>       if ( cpu_has_pge ) {
>               cr4 = read_cr4();
>-              write_cr4(cr4 & (unsigned char) ~(1 << 7));
>+              write_cr4(cr4 & ~X86_CR4_PGE);
>       }
>
>       /* Flush all TLBs via a mov %cr3, %reg; mov %reg, %cr3 */
>
>
>
>-------------------------------------------------------
>The SF.Net email is sponsored by: Beat the post-holiday blues
>Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
>It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxxxx
>https://lists.sourceforge.net/lists/listinfo/xen-devel


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel

<Prev in Thread] Current Thread [Next in Thread>