Re: [PATCH RFC 13/41] devpts: use fc_init_pseudo()

[Alexander Mikhalitsyn <alex@xxxxxxxxxxxx>]

On Tue, 2026-11-10 at 10:14 +0100, Christian Brauner wrote:
> Initialize devpts as a pseudo filesystem. This raises SB_I_PSEUDO and
> SB_I_NOEXEC. devpts never holds executables. devpts_fill_super()
> keeps
> clearing SB_I_NODEV for the pty device nodes.
> 
> Signed-off-by: Christian Brauner (Amutable) <brauner@xxxxxxxxxx>

Reviewed-by: Alexander Mikhalitsyn <alex@xxxxxxxxxxxx>

> ---
>  fs/devpts/inode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
> index bd1e8eb26edb..47ef12241d92 100644
> --- a/fs/devpts/inode.c
> +++ b/fs/devpts/inode.c
> @@ -13,6 +13,7 @@
>  #include <linux/init.h>
>  #include <linux/fs.h>
>  #include <linux/fs_context.h>
> +#include <linux/pseudo_fs.h>
>  #include <linux/fs_parser.h>
>  #include <linux/sched.h>
>  #include <linux/namei.h>
> @@ -438,6 +439,7 @@ static int devpts_init_fs_context(struct
> fs_context *fc)
>               fsi->mount_opts.reserve = true;
>  
>       fc->s_fs_info = fsi;
> +     fc_init_pseudo(fc);
>       fc->ops = &devpts_context_ops;
>       return 0;
>  }