Re: [PATCH] xen/link: Move SCHEDULER_ARRAY into .rodata

[Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>]

Hi,

Andrew Cooper <andrew.cooper3@xxxxxxxxxx> writes:

> This is a list of pointers which is only ever read.
>
> In the ARM linker file, fix some adjacent misalignment.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

> ---
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger@xxxxxxxxxxxxxx>
> CC: Teddy Astie <teddy.astie@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
> CC: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> CC: Michal Orzel <michal.orzel@xxxxxxx>
> CC: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> CC: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>
> CC: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  xen/arch/arm/xen.lds.S   | 6 +++---
>  xen/arch/ppc/xen.lds.S   | 2 +-
>  xen/arch/riscv/xen.lds.S | 2 +-
>  xen/arch/x86/xen.lds.S   | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> index 613511390ff4..d1bb6c62d208 100644
> --- a/xen/arch/arm/xen.lds.S
> +++ b/xen/arch/arm/xen.lds.S
> @@ -51,9 +51,10 @@ SECTIONS
>  
>    . = ALIGN(PAGE_SIZE);
>    .rodata : {
> -        _srodata = .;          /* Read-only data */
> +       _srodata = .;          /* Read-only data */
>  
> -        BUGFRAMES
> +       BUGFRAMES
> +       SCHEDULER_ARRAY
>  
>         *(.rodata)
>         *(.rodata.*)
> @@ -93,7 +94,6 @@ SECTIONS
>    .data : {                    /* Data */
>         *(.data.page_aligned)
>  
> -       SCHEDULER_ARRAY
>         HYPFS_PARAM
>  
>         *(.data .data.*)
> diff --git a/xen/arch/ppc/xen.lds.S b/xen/arch/ppc/xen.lds.S
> index 37256c8865a9..cddb70855307 100644
> --- a/xen/arch/ppc/xen.lds.S
> +++ b/xen/arch/ppc/xen.lds.S
> @@ -48,6 +48,7 @@ SECTIONS
>          _srodata = .;          /* Read-only data */
>  
>          BUGFRAMES
> +        SCHEDULER_ARRAY
>  
>          *(.rodata)
>          *(.rodata.*)
> @@ -84,7 +85,6 @@ SECTIONS
>      DECL_SECTION(.data) {                    /* Data */
>          *(.data.page_aligned)
>  
> -        SCHEDULER_ARRAY
>          HYPFS_PARAM
>  
>          *(.data .data.*)
> diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S
> index d9375a961697..250ee3f36f4f 100644
> --- a/xen/arch/riscv/xen.lds.S
> +++ b/xen/arch/riscv/xen.lds.S
> @@ -43,6 +43,7 @@ SECTIONS
>          _srodata = .;          /* Read-only data */
>  
>          BUGFRAMES
> +        SCHEDULER_ARRAY
>  
>          *(.srodata)
>          *(.srodata.*)
> @@ -91,7 +92,6 @@ SECTIONS
>      .data : {                    /* Data */
>          *(.data.page_aligned)
>  
> -        SCHEDULER_ARRAY
>          HYPFS_PARAM
>  
>          *(.sdata .sdata.*)
> diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
> index 8f943e11ead4..925848980219 100644
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -119,6 +119,7 @@ SECTIONS
>         __ro_after_init_end = .;
>  
>         BUGFRAMES
> +       SCHEDULER_ARRAY
>  
>         *(.rodata)
>         *(.rodata.*)
> @@ -297,7 +298,6 @@ SECTIONS
>    DECL_SECTION(.data.read_mostly) {
>         *(.data.read_mostly)
>  
> -       SCHEDULER_ARRAY
>         HYPFS_PARAM
>    } PHDR(text)

-- 
WBR, Volodymyr