Re: [PATCH] xen/link: Remove CONSTRUCTORS from linker script

[Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>]

Hi Andrew,

Andrew Cooper <andrew.cooper3@xxxxxxxxxx> writes:

> The other architectures inherited CONSTRUCTORS from x86, so just as with
> commit b7a7e346c710 ("x86: drop use of CONSTRUCTORS from linker script"), they
> should be dropped.
>
> The .ctors section is handled explicitly in all architectures.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

> ---
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger@xxxxxxxxxxxxxx>
> CC: Teddy Astie <teddy.astie@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
> CC: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> CC: Michal Orzel <michal.orzel@xxxxxxx>
> CC: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> CC: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>
> CC: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>
> CC: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> ---
>  xen/arch/arm/xen.lds.S   | 1 -
>  xen/arch/ppc/xen.lds.S   | 1 -
>  xen/arch/riscv/xen.lds.S | 1 -
>  3 files changed, 3 deletions(-)
>
> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> index 8d0954c90afd..b5ccc732bd8d 100644
> --- a/xen/arch/arm/xen.lds.S
> +++ b/xen/arch/arm/xen.lds.S
> @@ -95,7 +95,6 @@ SECTIONS
>         *(.data.page_aligned)
>  
>         *(.data .data.*)
> -       CONSTRUCTORS
>    } :text
>  
>    . = ALIGN(8);
> diff --git a/xen/arch/ppc/xen.lds.S b/xen/arch/ppc/xen.lds.S
> index b2159279169c..fee810791840 100644
> --- a/xen/arch/ppc/xen.lds.S
> +++ b/xen/arch/ppc/xen.lds.S
> @@ -86,7 +86,6 @@ SECTIONS
>          *(.data.page_aligned)
>  
>          *(.data .data.*)
> -        CONSTRUCTORS
>      } :text
>  
>      DT_DEV_INFO                       /* Devicetree based device info */
> diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S
> index d1c5ce59c90d..4dc55f5ad26f 100644
> --- a/xen/arch/riscv/xen.lds.S
> +++ b/xen/arch/riscv/xen.lds.S
> @@ -93,7 +93,6 @@ SECTIONS
>          *(.data.page_aligned)
>          *(.sdata .sdata.*)
>          *(.data .data.*)
> -        CONSTRUCTORS
>      } :text
>  
>      DT_DEV_INFO                       /* Devicetree based device info */
>
> base-commit: 4263fe42b736596cfa5bfec661f2f55f02759aa7
> prerequisite-patch-id: 680071148129321ffaf7bd7435d031904014f556
> prerequisite-patch-id: 4ebfc2a1d8cd14cc1cf477b6db8cc9ef72310674

-- 
WBR, Volodymyr