[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RFC 36/41] nvmet: refuse files on pseudo filesystems as namespace backing files
- To: linux-fsdevel@xxxxxxxxxxxxxxx
- From: Christian Brauner <brauner@xxxxxxxxxx>
- Date: Tue, 10 Nov 2026 10:14:52 +0100
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="From:Date:Subject:References:In-Reply-To:To:Cc"
- Cc: Jann Horn <jannh@xxxxxxxxxx>, Chris Mason <mason@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, driver-core@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, selinux@xxxxxxxxxxxxxxx, apparmor@xxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, fuse-devel@xxxxxxxxxxxxxxx, linux-efi@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, Amir Goldstein <amir73il@xxxxxxxxx>, linux-erofs@xxxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, "Christian Brauner (Amutable)" <brauner@xxxxxxxxxx>
- Delivery-date: Tue, 10 Nov 2026 09:20:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
The file backend takes any path that isn't a block device. With
buffered_io=1 that includes files on procfs or sysfs which then get read
and written by a kernel worker on behalf of the host. Refuse files on
pseudo filesystems just like loop does.
Signed-off-by: Christian Brauner (Amutable) <brauner@xxxxxxxxxx>
---
drivers/nvme/target/io-cmd-file.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/nvme/target/io-cmd-file.c
b/drivers/nvme/target/io-cmd-file.c
index dfa8aa46188c..71c69bac5394 100644
--- a/drivers/nvme/target/io-cmd-file.c
+++ b/drivers/nvme/target/io-cmd-file.c
@@ -52,6 +52,11 @@ int nvmet_file_ns_enable(struct nvmet_ns *ns)
goto err;
}
+ if (file_is_pseudo(ns->file)) {
+ ret = -EINVAL;
+ goto err;
+ }
+
nvmet_file_ns_revalidate(ns);
/*
--
2.53.0
|
