[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/2] xen/riscv: fix the base ISA checks in riscv_isa_parse_string()
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>
- Date: Mon, 09 Nov 2026 14:21:27 +0100
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References:Feedback-ID"
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Alistair Francis <alistair.francis@xxxxxxx>, Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Mon, 09 Nov 2026 13:21:41 +0000
- Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, 09 Nov 2026 13:49:37 +0100, Oleksii Kurochko
<oleksii.kurochko@xxxxxxxxx> wrote:
> riscv_isa_parse_string() is meant to reject a riscv,isa string which
> doesn't start with "rv32" or "rv64" (depending on Xen's bitness), but
> the checks are written with && instead of ||, so a string is rejected
> only when both characters of a pair are wrong. As a result, e.g.
> "xv64i" or "rv62i" is accepted on RV64. Also, for a string as short as
> "rv", isa[3] is read past the terminating NUL.
>
> [...]
Reviewed-by: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>
--
Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>
|
