[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v13 13/14] xen/arm: Add vPSCI SYSTEM_SUSPEND policy
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Date: Mon, 9 Nov 2026 13:25:04 +0200
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=7vd28LUNAcXQYC8IquR/rqALyr+9bzLZGM4hS9fWKb4=; fh=otM5Y3HSqWrnegtZP/S+KnL4PqF4qzydXT2sQ05LBPg=; b=UsNqXB9JcZIM/HxQ0LoqVM0l/CF6ViA8xvx1JDuwQD1XtA5b91Ly+8WyT9Ei9bvULR f8RinQ6w23DZDECXnSatCnU8F0ZWb9RXtJ37iQmqrIdxG4mSf2uHqw0kUC0seZWD6NZo bq46ScIA2URD1Izo+zRoT4rh9dIsVvSFiNXYivf0OnGz6+WKik/ARn2aciurWz2TkxKF G1eocXU1blItCxB0hmcVvwh9pvf4R3Y4QCLzYqreKk0nV94DDbc3fw2GTq3AiJbHBKUF EN5bKA0Vu11euw4GZELZebnP/zbc1OUnWortRwGPHb5yPvE+hmzOwXZjg6RdcrW1EzGp 3l+w==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1794223515; cv=none; d=google.com; s=arc-20260327; b=oB7/q4cih3SUu6DTIuJDPiDbyqUCjA7l5Xw1NyDslX0JloC34lBiufypHa+QzbWU8L 1JIcoEV3otr0Xphn4nMnFohONTWlY6Zdr/O7FH1GjmnxqUo0DJILUZex9KVhPaPo8lV+ UyxMnZPE44SsiTSAVM4g+LU9I35oYppSIXhEkV7xmqWWFPEpWA8EQqz7NP6ZfY9wGaB8 PphxqQ9moDNw1wZdX2MIESub1RJzkX5DOEaoe7zYHOBM86k6NQQ3wffJkzV7q8JK3y2O aSgCT8Iu3x/A1Wp1Sx3q7kbTzyErD/b6VhrOZ4GAOSYlWBwJYVBD6dcSqborEPF/SOEn 5fzw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20260707 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Mykyta Poturai <mykyta_poturai@xxxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 09 Nov 2026 11:25:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jan,
Thank you for the review.
On Wed, Oct 28, 2026 at 9:27 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 27.10.2026 22:06, Mykola Kvach wrote:
> > --- a/xen/arch/arm/Kconfig
> > +++ b/xen/arch/arm/Kconfig
> > @@ -19,6 +19,7 @@ config ARM
> > select HAS_ALTERNATIVE if HAS_VMAP
> > select HAS_DEVICE_TREE_DISCOVERY
> > select HAS_DOM0LESS
> > + select HAS_HWDOM_SYSTEM_SUSPEND if !MPU
>
> Why the !MPU dependency? Nothing is being said in this regard in the
> description,
> unless I overlooked something.
I kept !MPU to preserve the current hardware-domain shutdown behaviour
on MPU systems. This series does not add suspend support for Cortex-R,
and I have not tested suspend/resume there. I should have explained
this in the commit message.
This option lets the hardware domain suspend while Xen keeps running.
A separate control domain can resume it. This can also be used on ARM32
MMU systems. Host suspend is a separate feature.
>
> > --- a/xen/drivers/char/serial.c
> > +++ b/xen/drivers/char/serial.c
> > @@ -490,6 +490,8 @@ const struct vuart_info *serial_vuart_info(int idx)
> >
> > #ifdef CONFIG_SYSTEM_SUSPEND
> >
> > +static bool __ro_after_init serial_suspend_available = true;
>
> Nit: I'm not going to insist on a change to the name, but prefixing a static
> variable in a file named serial.c with serial_ looks redundant to me. (I'm
> also inclined to suggest s/available/possible/, seeing how the variable is
> set / used.)
Agreed. I'll rename it to suspend_possible.
Best regards,
Mykola
>
> Jan
>
|
