Re: [PATCH] tools/ocaml: Fix cleaning bindings test

[Andrii Sultanov <andriy.sultanov@xxxxxxxxxx>]

On 11/7/26 00:11, Jason Andryuk wrote:

> On 2026-11-06 18:19, Andrew Cooper wrote:
> > On 06/11/2026 11:17 pm, Jason Andryuk wrote:
> > > make clean fails in the bindings tests:
> > >
> > > make[7]: Entering directory '/home/amd/xen/tools/ocaml/tests/bindings'
> > > rm -f .*.d *.o *.so *.a *.cmo *.cmi *.cma *.cmx *.cmxa *.cmxs 
> > > *.annot *.spot *.spit unix.cmxa -ccopt -L -ccopt ....
> > > rm: invalid option -- 'c'
> > > Try 'rm --help' for more information.
> > >
> > > Split the compiler flags out of the LIBS variable, since LIBS is passed
> > > to rm.  The individual *.cxma files are deleted in their respective
> > > directories.
> > >
> > > Fixes: d97847e858f1 ("tools/ocaml: Gitlab CI test for bindings")
> > > Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
> > Lovely...  Sorry for breaking this.
> >
> > Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Thanks.  I just double checked and unix.cmxa isn't in the directory on 
> a successful build.  So the whole thing could be moved to LIBFLAGS or 
> a suitable name.
> Regards,
> Jason
Could we follow tools/ocaml/xenstored/Makefile further and
move to BINDINGSLIBS or something like that?