[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 16/20] xen/riscv: implement IRQ routing for device passthrough
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Date: Mon, 14 Sep 2026 14:23:05 +0200
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Cc: Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>, Zheng Zhang <zhangzheng@xxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 14 Sep 2026 12:23:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 9/14/26 1:36 PM, Jan Beulich wrote:
On 14.09.2026 12:54, Oleksii Kurochko wrote:
On 9/10/26 2:53 PM, Jan Beulich wrote:
On 09.09.2026 17:07, Oleksii Kurochko wrote:
--- a/xen/arch/arm/irq.c
+++ b/xen/arch/arm/irq.c
@@ -205,7 +205,7 @@ void __init init_IRQ(void)
static inline struct irq_guest *irq_get_guest_info(struct irq_desc *desc)
{
ASSERT(spin_is_locked(&desc->lock));
- ASSERT(test_bit(_IRQ_GUEST, &desc->status));
+ ASSERT(desc->status & IRQ_GUEST);
ASSERT(desc->action != NULL);
return desc->action->dev_id;
Why did an Arm change slip into a RISC-V patch?
Considering that this code is executed under the spinlock it is fine to
not use test_bit() so it is part of dropping of bitops functions.
Perhaps, but then in a separate patch and changing all places consistently
(I didn't go check, but I'm pretty sure there are more).
Oh, sorry, it is really Arm file. I overlooked that... It shouldn't be
really touched in this patch.
~ Oleksii
|
