[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New Defects reported by Coverity Scan for XenProject


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 14 Sep 2026 11:27:30 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
  • Delivery-date: Mon, 14 Sep 2026 09:27:44 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 13.09.2026 19:31, scan-admin@xxxxxxxxxxxx wrote:
> 1 new defect(s) introduced to XenProject found with Coverity Scan.
> 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
> recent build analyzed by Coverity Scan.
> 
> New defect(s) Reported-by: Coverity Scan
> Showing 1 of 1 defect(s)
> 
> 
> ** CID 1701169:       Control flow issues  (DEADCODE)
> /xen/arch/x86/hvm/hvm.c: 5136           in do_hvm_op()
> 
> 
> _____________________________________________________________________________________________
> *** CID 1701169:         Control flow issues  (DEADCODE)
> /xen/arch/x86/hvm/hvm.c: 5136             in do_hvm_op()
> 5130             rc = -EINVAL;
> 5131             if ( unlikely(d != current->domain) )
> 5132                 rc = -EOPNOTSUPP;
> 5133             else if ( is_hvm_domain(d) && paging_mode_shadow(d) )
> 5134                 rc = xsm_hvm_param(XSM_TARGET, d, op);
> 5135             if ( !rc )
>>>>     CID 1701169:         Control flow issues  (DEADCODE)
>>>>     Execution cannot reach this statement: "pagetable_dying(a.gpa);".
> 5136                 pagetable_dying(a.gpa);
> 5137     
> 5138             rcu_unlock_domain(d);
> 5139             break;
> 5140         }

Nothing really changed here recently, so how can this be a new violation?
It's presumably related to SHADOW_PAGING=n by default now, but that change
was done a while ago.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.