[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] acpi: reboot: log reset parameters
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: dmukhin@xxxxxxxx
- Date: Wed, 29 Jul 2026 17:18:55 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 205.220.161.53) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sIEHNcXzFwhxwKUbaYsNjyDEFklQxVKPHFW+JOEsbd4=; b=Wd7qLNoeuzfmkRI932coAzZY1QLBBjTVWhIQMefqJ4MHpH263FFWDZiLWHYBrQOomYepRMOFm7DSsKay7ULxM+zqdz1h2iwkogV0WVGypoCOWEaLtbaHVlwEJkc38JDkHKkqu4W1LonV6Lqx/5W91lLn9Dkbxs2vjAsWJ6qaPCAv7bgj4cLsDfBjOKcwqagFi3bHW9+ky2IdC7fyakNjPMJAb+zuOHreG57xg32lVzvXxL8MKW0TO/nq7B+a+yqv9Bf+Pl4hhAPJ43WJF3BnMldlAiKUo/OoEZGWUX4X7YRRApcuNNq7noC+9CMDcA2fPJFKTRS4N0j47puJCyNwZA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I2a1ExEmkt+MPP5dDVq4J1ZkPQtPANE8XO5Y4FrVQjaZxZ14X52uVuF4U2Jf8Roq03HVrOABSPpPq0J1kcSb7H39eCByCGo3hh3KRIB05jdqFrxDVezuQOpz2Q0gm8bVu3x6qRAugIiP4xBNKrYkejA1wAZNmQx9IAY/Komqzifs11RTXWOcBil6bLWq65sKLEoOqcAyrTPqtDPOuvaB3ZizxqUvAabWPI8mY3IYal+UvBhpiaJXCeSn2s2/j+G9o/Bx6VsKcfF3Drv+7BX6OWAM/MMmi5tu6nkHsoD73PIh1Kh7+VimEDgGMQd4fJWeOLmKDPLnni5YRhMmtRLUxA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:Message-ID:MIME-Version:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:Message-ID:MIME-Version:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:Message-ID:MIME-Version:Subject:To"
- Cc: andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, jbeulich@xxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, dmukhin@xxxxxxxx
- Delivery-date: Thu, 30 Jul 2026 00:19:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Pser-m365-app: SER-APP
From: Denis Mukhin <dmukhin@xxxxxxxx>
Xen does not provide much details for system reset debugging in case
system reset happens via ACPI subsystem.
Log reset I/O address and reset value.
While here, fix the missing default case, guard it with
ASSERT_UNREACHABLE() and drop full stops in the loglines.
Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
---
CI: https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2716843348
---
xen/drivers/acpi/reboot.c | 22 +++++++++++++++-------
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/xen/drivers/acpi/reboot.c b/xen/drivers/acpi/reboot.c
index f6345be8749f..3b0437395674 100644
--- a/xen/drivers/acpi/reboot.c
+++ b/xen/drivers/acpi/reboot.c
@@ -6,6 +6,7 @@ void acpi_reboot(void)
{
struct acpi_generic_address *rr;
u8 reset_value;
+ pci_sbdf_t sbdf;
rr = &acpi_gbl_FADT.reset_register;
@@ -21,17 +22,24 @@ void acpi_reboot(void)
* on a device on bus 0. */
switch (rr->space_id) {
case ACPI_ADR_SPACE_PCI_CONFIG:
- printk("Resetting with ACPI PCI RESET_REG.\n");
+ sbdf = PCI_SBDF(0, 0, rr->address >> 32, rr->address >> 16);
+ printk("Resetting with ACPI PCI %pp RESET_REG at 0x%"PRIx64"
(0x%x)\n",
+ &sbdf, rr->address & 0xffu, reset_value);
/* Write the value that resets us. */
- pci_conf_write8(PCI_SBDF(0, 0, rr->address >> 32,
- rr->address >> 16),
- (rr->address & 255),
- reset_value);
+ pci_conf_write8(sbdf, rr->address & 0xffu, reset_value);
break;
case ACPI_ADR_SPACE_SYSTEM_MEMORY:
- case ACPI_ADR_SPACE_SYSTEM_IO:
- printk("Resetting with ACPI MEMORY or I/O RESET_REG.\n");
+ printk("Resetting with ACPI MEMORY at 0x%"PRIx64" (0x%x)\n",
+ rr->address, reset_value);
acpi_hw_low_level_write(8, reset_value, rr);
break;
+ case ACPI_ADR_SPACE_SYSTEM_IO:
+ printk("Resetting with I/O RESET_REG at 0x%"PRIx64" (0x%x)\n",
+ rr->address, reset_value);
+ acpi_hw_low_level_write(8, reset_value, rr);
+ break;
+ default:
+ ASSERT_UNREACHABLE();
+ break;
}
}
--
2.54.0
|
