[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v6 5/5] xen/acpi: Parse PPTT to initialize CPU topology
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Hirokazu Takahashi <taka@xxxxxxxxxxxxx>
- Date: Fri, 17 Jul 2026 00:35:28 +0000
- Accept-language: ja-JP, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aoWRHa4xF/l4LzpvetZuoD3h/B4XloEuOzvYZ6X+OWw=; b=nnYlIP1ctuYKwUwnaCIH6F565elZuCAiP6LOL82UI0q9IYTE7SLIsm/h6ufZ3OlwDntkfbpCUa53+jADh4iZjVfr/ZFJyX1A2vjdwI6Y3Q+8LcOwZ5dNl7FSXsjL6d3tNt7lPBsGgcwHep9We6ewFTwPaJ7kQYKP8bTBWUhdN+yewE41STK4jdFzYT6Xg8+naLTSvjGrEvIJsw5lTuRlwC7T26gVW8cAxDTRYfp6W7gAdaP+X0zuasSvQLcxQRZeLlWUjMvs2ngx1G6Rd4BGke1BQOzUITQXUvqNYpS+sxuhKYtLWpM+xuCnZ0W2P7GHkGvs7gb2eYHZOQLtmuBMyA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q0hk9BrjaAkaQC0rgoFxaGYJEclKJb7LUIUI2Y/FksRFEGdvaNLAa9ieUMXvSqxNY2my3cF2xggZjAKeypKXL5rlqZhl9fR5RguqzWx6eu9nnX4HMDla90975B/KXWnIzo2lRaDQCaY2Pgqw9aOmz+Y8ajn7o6fN3o+hfAGQo/Y0XxbJogwp/XqakpliICsy+5kzKtXvxR2N6yRPl06oJfefzPvMVFBMSvs6FegDkV7IBB+aB1EKKIA7flCn2B7aL8wPwv5BgWwTthuCbBs0hriGN6H8yG7XRBfUQS1tib63WEi6jaJCdz2aZgzuoNvjEgBJZPhmVUZKhpXH03RgBQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
- Cc: "Mykyta_Poturai@xxxxxxxx" <Mykyta_Poturai@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 17 Jul 2026 00:35:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdE336EabuJxSEHUSo4bExE1f467ZthrLggAAB8dCAAJJWgIACxhTw
- Thread-topic: [PATCH v6 5/5] xen/acpi: Parse PPTT to initialize CPU topology
Hello,
> >>> --- a/xen/drivers/acpi/topology.c
> >>> +++ b/xen/drivers/acpi/topology.c
> >>
> >>
> >>> int __init acpi_init_cpu_topology(void)
> >>> {
> >>> + acpi_status status;
> >>> + struct acpi_table_header *table_header;
> >>> + const struct acpi_table_pptt *pptt;
> >>> + unsigned int num_sockets = 0;
> >>> + unsigned int num_clusters = 0;
> >>> + unsigned int num_cores = 0;
> >>> + unsigned int *socket_map = xmalloc_array(unsigned int,
> nr_cpu_ids);
> >>> + unsigned int *cluster_map = xmalloc_array(unsigned int,
> nr_cpu_ids);
> >>> + unsigned int *core_map = xmalloc_array(unsigned int,
> nr_cpu_ids);
> >>
> >> These have to be xzmalloc_array().
> >
> > xzalloc_array()
>
> xvzalloc_array(). And the others xvmalloc_array(). See the top of
> xen/xvmalloc.h.
Yes, you are right. I will fix it.
Hirokazu Takahashi.
|
