[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 4/4] xen/console: reduce number of printouts in __printk_ratelimit()
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: dmukhin@xxxxxxxx
- Date: Wed, 15 Jul 2026 13:19:02 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 148.163.138.245) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XKaFHZ5ktm+3TGN1OySPqg+Yp5lz/RpEQwE5SjNSLQc=; b=SuHfF9TDVD3teGaqxrHFXteZ9/g+ONVrLe7udpdyWHAhF+BuN5oucK9JGD6aOXnqYg7qT/wk4kobudhcr0VA7bvRZm2D0iInQ4zxU+yb1deZoyJXdH4XZc0Nc86KwGme4pq59b1+BnA9ojPyCcZDfAQpBTuoe8ayH9Q8k0qsksAf8hr48+2cgH53deglpXV95hHz1x2DHtHgWyqRC9I0DEbF/PK9ScAB8MMJzOg6YX0qF0inx+oSD9fr1wJc4lQL7QKBGUry+wO3rLIpYs1jML9GFMzmBQK5ph3DMB2GZIdbITv+iVR5LK3qikKiN7lkZ5PHdSEePoQ4gTRY+rUqKg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kWJS/Dd9l/tB1h1V0FjIFQwSvQ+l0JUEjnv1DVwi4xtZPNS/uNyVOYqOv4HNvsXRg0cssNvKLeGJKJHtRR0j4pA1V/9qUU/gNwppUkQ3mvhW0kEGHmgCGVP6andkK9G3O2mpevlIqeH3eR/JYSNjAxgnDZCWWsa6AfpxaHUti4QEyLISG2weLNMgQznihgza+wPwvXC/eW99j8XQ17lLBXNxq+y2BAxbeI5O5J+nlFOq+ykjpfhA2crOpp4im1ix4OQhKv+vGp3DXqdSZ2oSVTzNW3LtVAY+rDU9oKK8uiEDO49ZJ9erEJPMhO6tai00a6Gf9b91ESN7vyymkEsPyw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"
- Cc: andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, jbeulich@xxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, dmukhin@xxxxxxxx
- Delivery-date: Wed, 15 Jul 2026 20:19:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Pser-m365-app: SER-APP
From: Denis Mukhin <dmukhin@xxxxxxxx>
Fold several __putstr() calls into one around notification of how many
messages have been rate-limited.
Not a functional change.
Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
---
Changes since v2:
- corrected the commit message
---
xen/drivers/char/console.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index a9520f5521e4..f9a565fc59bc 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -1303,15 +1303,15 @@ bool __printk_ratelimit(unsigned int ratelimit_ms,
spin_unlock(&ratelimit_lock);
if ( lost )
{
- char lost_str[10];
+ char msg[64];
+
+ snprintf(msg, sizeof(msg),
+ "printk: %u messages suppressed\n", lost);
- snprintf(lost_str, sizeof(lost_str), "%u", lost);
/* console_lock may already be acquired by printk(). */
rspin_lock(&console_lock);
printk_start_of_line(CONSOLE_PREFIX);
- __putstr("printk: ");
- __putstr(lost_str);
- __putstr(" messages suppressed.\n");
+ __putstr(msg);
rspin_unlock(&console_lock);
}
local_irq_restore(flags);
--
2.54.0
|