|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH v3 1/4] xen/console: use bool as return value from printk_ratelimit()
From: Denis Mukhin <dmukhin@xxxxxxxx>
{__,}printk_ratelimit() are predicates. Make that pronounced by updating the
return value to boolean.
Not a functional change.
Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
---
Changes since v2:
- rebased
---
xen/drivers/char/console.c | 9 +++++----
xen/include/xen/lib.h | 6 +++---
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index dbda7f259668..5d395f882e08 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -1270,7 +1270,8 @@ void console_end_sync(void)
* This enforces a rate limit: not more than one kernel message
* every printk_ratelimit_ms (millisecs).
*/
-int __printk_ratelimit(unsigned int ratelimit_ms, unsigned int ratelimit_burst)
+bool __printk_ratelimit(unsigned int ratelimit_ms,
+ unsigned int ratelimit_burst)
{
static DEFINE_SPINLOCK(ratelimit_lock);
static unsigned long toks = 10 * 5 * 1000;
@@ -1309,11 +1310,11 @@ int __printk_ratelimit(unsigned int ratelimit_ms,
unsigned int ratelimit_burst)
rspin_unlock(&console_lock);
}
local_irq_restore(flags);
- return 1;
+ return true;
}
missed++;
spin_unlock_irqrestore(&ratelimit_lock, flags);
- return 0;
+ return false;
}
/* Minimum time in ms between messages */
@@ -1322,7 +1323,7 @@ static const unsigned int printk_ratelimit_ms = 5 * 1000;
/* Number of messages we send before ratelimiting */
static const unsigned int printk_ratelimit_burst = 10;
-int printk_ratelimit(void)
+bool printk_ratelimit(void)
{
return __printk_ratelimit(printk_ratelimit_ms, printk_ratelimit_burst);
}
diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h
index bb0fd446b484..3c545ff33c61 100644
--- a/xen/include/xen/lib.h
+++ b/xen/include/xen/lib.h
@@ -82,9 +82,9 @@ extern void guest_printk(const struct domain *d, const char
*fmt, ...)
__attribute__ ((format (printf, 2, 3)));
extern void noreturn panic(const char *fmt, ...)
__attribute__ ((format (printf, 1, 2)));
-extern int __printk_ratelimit(unsigned int ratelimit_ms,
- unsigned int ratelimit_burst);
-extern int printk_ratelimit(void);
+extern bool __printk_ratelimit(unsigned int ratelimit_ms,
+ unsigned int ratelimit_burst);
+extern bool printk_ratelimit(void);
#define gprintk(lvl, fmt, args...) \
printk(XENLOG_GUEST lvl "%pv " fmt, current, ## args)
--
2.54.0
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |