[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 for-4.22? 5/7] domctl: correct return value of XEN_DOMCTL_[gs]etvcpuaffinity
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 17 Jun 2026 13:45:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wDfhH4bAKEwdmui17ju4yeJwSls5YX5WpJoqWbmsB7I=; b=v9odkOhyiVHvhEYu00Oh1njIpa2RJHqI0MWjIN3E4UnAhWG7/esxOfxDMzHezKnxiDqJftu/+LSY6vB0FPJEEijcAzRT5SXzWyJv1p6OjTBF3m9DXqONHkwvaZ+TwMq4tWYN8oFBZjW/9rop2hyB3sntgAXk6pt+jju40qj6SJsuf8eEhYxglOlXZcVKCyPKIu4se8r19LGkrF9dVOm6HSvHdaXqlLv4sAztGmeXgnJdKGMsP6DA5qRjpIqbPPilmL6nR8Lhs6uLsix+b394lZ2yEZSteTiYQx4sDWL9adp2sJP8WKiELP4A40xeJ+c5bCrHaW0Dub3Ti7PCf+qE9Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L3MTbcwH8491u/ghdLBjpo1ZuxwYItauTt80aR7O2tYMQ4tJEV6pgJmRs6GReQ6m9H0ZUNw6/RRLBgnFfJ1WOubBCQOXDzq3gY4VDemJoTTLUczkpYoSbj4dO+XHrmUlLhC6RtDg8NOr/nfhGgmzOzCEtAOzEum5b5eFD7zjqEr1TJbWshVq1AqEXbSVkiwaBGqweXsqEDBtHlk4UB3OJpkVezLiEqRqVodWD1AL+EAi9oZx9iJcvRS10Fl6JaQZTAi9o4EsWaagOHnj6StjtUnU09f4kX8aMcNAmTBS4pak3VRkTPQGAaGvt0Q49I4WF3m/Lto4MMklQqdBL05I/A==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>
- Delivery-date: Wed, 17 Jun 2026 11:45:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jun 17, 2026 at 11:29:09AM +0200, Jan Beulich wrote:
> cpumask_to_xenctl_bitmap() may return errors. Clearing the error indicator
> of an earlier such call by a (successful) later call is misleading the
> caller. For "set", keep setting soft affinity if the hard affinity copy-
> back fails; only accumulate respective errors.
>
> While fiddling with return values, also drop a redundant clearing of
> "ret". This eliminates a Misra C:2012 rule 2.2 ("There shall be no dead
> code") violation.
>
> Fixes: 6e4ecc6d5884 ("sched: DOMCTL_*vcpuaffinity works with hard and soft
> affinity")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
