Re: [PATCH for-4.23] xen/kexec: Drop the obsolete v1 hypercall implementation

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 6/12/26 12:27 PM, Andrew Cooper wrote:
> The v1 interface was declared obsolete in Xen 4.4 (2013) when kexec in Xen was
> overhauled.
>
> The only known user of the v1 interface was the classic-xen fork of Linux.
> Linux PVOps does not interact with Xen kexec directly, delegating it entirely
> to userspace (i.e. kexec-tools).  Xen support in kexec-tools was part of this
> work, and uses the "new" interface.
>
> As such, there's no way to test changes to the interface any more.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> CC: Michal Orzel <michal.orzel@xxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> CC: Kevin Lampis <kevin.lampis@xxxxxxxxxx>
>
> For 4.23, but I'd like to get this into my for-next branch nowish so other
> work can be rebased over it.
>
> This patch will need rebasing over release activities in CHANGELOG.md but
> that's easy to do.
>
> Bloat-o-meter reports:
>    add/remove: 1/3 grow/shrink: 0/4 up/down: 152/-1431 (-1279)
>    Function                                     old     new   delta
>    kexec_swap_images                              -     152    +152
>    symbols_sorted_offsets                     69592   69576     -16
>    symbols_offsets                            53668   53652     -16
>    symbols_names                             135309  135272     -37
>    do_kexec_op_internal                        2038    1994     -44
>    kexec_do_unload.isra                         170       -    -170
>    kexec_load_slot                              510       -    -510
>    kexec_do_load_v1                             638       -    -638
> ---
>   CHANGELOG.md               |   8 ++
>   xen/common/kexec.c         | 241 +------------------------------------
>   xen/include/public/kexec.h |  45 +------
>   xen/include/xlat.lst       |   1 -
>   4 files changed, 13 insertions(+), 282 deletions(-)
>
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index 5cf19372a361..5c1113ab61af 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -4,6 +4,14 @@ Notable changes to Xen will be documented in this file.
>   
>   The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>   
> +## [4.23.0 UNRELEASED](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD
> +
> +### Removed
> + - On x86:
> +   - The kexec "v1" interface, which was declared obsolete in Xen 4.4 (2013).
> +     The only know user was the classic-xen fork of Linux.  This does not
> +     affect Xen kexec support in the kexec-tools package.
LGTM:

Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx> # CHANGELOG.md

Thanks.

~ Oleksii