[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 1/3] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Hirokazu Takahashi <taka@xxxxxxxxxxxxx>
  • Date: Fri, 12 Jun 2026 02:29:17 +0000
  • Accept-language: ja-JP, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gKJ7525aI43XAvJkR0xaZW/9PUK0Anwv8gVMuiigYEo=; b=l+anIFn/AdqFdtfXW3ia3UF78kBgZnDdRln0YFC8l3oL+TwkF3qmFGlD92pa17CSxapGEIF8l2AmkOMz8iwLIW2WLkpkZ+9KWKLl4+fe95X1oEDQZRkWc4a4jGdJH1rlPRgvqM+23EfYTBUHIRICz3IzKgbrjLtGQilSdeNDRMkOzVf14qBPPCtZV0PIz7ImwyNZd1p6XvWX223obnAY80uHQNBwdgstj2SZOf6mjuGndMjWYV84p9ihqH0Ged5LniKeZ6XuFkAdVyEcPi3BJSzYyoaBHcmY447TBz8vmltxYPOVhXLx00U1euAGWG+z5Rtsik/oaFQ01ZSRqWrcfg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S+FSKfsBZhSnlEkjTQ3qJN/Lfo+FvSu2rSm3+ZYX79QqRCAovbGKKzdaG5/dCelClWr9gT8nM3+6TXmz6/H1A2ZaALwjDVtuDPVsYm1QuWD7vb8wlAoW2twCG/lEzhOpk3PPOALvc+MC6047NHkcS4FHkjmTg8QSoSF3YFWkdPo1YtyexhTiPQqPLUXQ3/GsjLCfNbcSV25YP6M97Wzeig6BXEEw2JWInALoJS0URmdSFq33D4eAEzFyuGduQTjoJ1BNP0grVxMJf8kRqOUfFMC7kRnLnvjNC88bUkZt+I3lLWoFmjCYyFbpCtooq05+inJ9G99Ge6dBpWYPHnxewA==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
  • Cc: "Mykyta_Poturai@xxxxxxxx" <Mykyta_Poturai@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 12 Jun 2026 02:29:45 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHc+MoozrCC9Pa1YkC7YJKVJ6P2UbY5ZUuAgADOheA=
  • Thread-topic: [PATCH 1/3] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration

Hello, 

Thank you for the feedback.

> > --- /dev/null
>

> The name of the new file does not in any way

>... express this is all about DT stuff. Is this intentional? Else it
> may want adjusting.

To address the immediate concern, I agree with renaming the file
to 'dt-cpu-topology.h' in v2, since the current implementation is
purely Device Tree-based.

However, my original intention behind the generic name was to
accommodate future enhancements. Since ARM Xen supports both Device
Tree and ACPI-based boots determined at runtime, I hoped to allow
ACPI boots to populate and share the same underlying topology data
structure. I think this can be achieved by scanning the ACPI PPTT
(Processor Properties Topology Table).

> > +#elif CONFIG_DEVICE_TREE_PARSE
>
>DYM "#elif defined(CONFIG_DEVICE_TREE_PARSE)"?

Oops, I will fix it.

Thank you,
Hirokazu Takahashi.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.