[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 0/2] domctl: Avoid taking domctl lock for certain ops used during migration
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Wed, 10 Jun 2026 10:57:08 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZLYJe34Z6WHlwoSJDhl1LQvPgiztpz7D02TDA3ys6oE=; b=kShlEGDy3iqNjEENc1QNTf4iaASkem0Za0Z6EIVCkJuVP6h5pG1XiHX/Ma561W126+T9vdB6GViAGT+EKUhZQp+gwQZtXkAd4JB/y5eecn01OEGpqVeH3/R6BvnSDctJdkeKyoYnFc4n5xYkvHblFc3vnHfUARCqUUx0PMvT74HQBKqMQkojr60FhLCbAuEBbLkiAjtrtptD0oEPVyZU/mnSBi5bmvgCFEm/bUzmrcgDowNFp78f3X4BcxfbNeT0gqFo69fZ7cjo09lriwoNdWNw1VCUplINK8Ihmpu4AX00c8cmFTKk4AXwvzJxkKxA+QvHfYaD6ifKd8sNNDFT/w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Fg+nROkMJAuEMP6MJFS8Z3YPwCnZn0F2m5jqGLqLcfvhc6ySAKbgfwOXZQrg7CWVuxCwuezS95IV5HEwFNVtG0GBrdbSRnbfOdC5JgcgHiTK8F0jm16iyN2cRV25c2IuIFkzWmQBBZZZjbEozG7beLcarAjBG+O/w0CZNcqtW2MZjhARcIdu3sRP2Xerul9WqES7t763eRok80x8s4kkujS8AcrLrYdGPpDd/pcc42ffpFB++z+XvDwtwrl3xN2c8gr2jC5zSLrx0OuZnGg78mMa1CBFO5VZyiHnFSbmjgS5JMaaxmS7oJwoscM+ErR8lMskQ307an/Rfgv4S8dd1w==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Wed, 10 Jun 2026 09:57:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 6/9/26 4:15 PM, Ross Lagerwall wrote:
When performing multiple migrations in parallel, the domctl lock may
become extremely contended:
* Operations like "xl vcpu-list" were observed to take in excess of 20s
to execute.
* The "clean" shadow op may pause the domain, restart with a
continuation and then become blocked on the domctl lock, causing VM
downtime in excess of 20 seconds.
These issues can be fixed by not holding the domctl for the frequently
called operations during migration.
Thanks
Ross Lagerwall (2):
domctl: Handle XEN_DOMCTL_getpageframeinfo3 without the domctl lock
domctl: Handle some of XEN_DOMCTL_shadow_op without the domctl lock
xen/arch/x86/domctl.c | 4 ++++
xen/arch/x86/mm/paging.c | 8 ++++++--
xen/common/domctl.c | 13 +++++++++++++
3 files changed, 23 insertions(+), 2 deletions(-)
I'd like to request inclusion of this in 4.22 since it fixes a real
customer issue we have observed and would have been posted some time ago
but was delayed to avoid drawing attention to and colliding with
XSA-492.
Thanks,
Ross
|
