[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.22] xen/x86: Always strip xen.efi
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 10 Jun 2026 09:31:03 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+qCusDfXLPo6FSyos7dqcr8VokFVlL3Z45lxOvArRpg=; b=tHskxp83NfPYuu8ui5jiugXA2i/gLFebwpT9fiWUMqMkjI9odB3xSD8fDaAfPKCHX51xb+1UvA8NfqYFQ3O6LazLoLFc/AoCGMAWNNMn+8v/Wb26QpQYk4YGz+rHDBENLtHSngTYQsHDyjUMb7XZS375bX0BLTHSIdOd7FbqzAvdGxCT7joy6Rzg3LgzOUcdBky0I1BAImr5sJlERIlKeE02kqrdPa/bvZStLRr7vAFDrbtJ9Ed2m4NAtOtvnu2ynZcpfnhKJePo9uPuZvpoW5wbRaL/+YT9q+1Lz7nsT0ypdw2Vh27mrt9gIK/sYUKmKGKct8qYOCUAcqRYZYVGLw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Um64GGzMUSASEAcjCGMW5bj04+pto7PpyFIrbZe9eQOFfQy0+SSeBGXeIEwk6WQelU32lMr/pev/T4GcyQ02VZp/3z8nRF2MXuvrabtDQ/UQeDjcCrvapwZyj1IqP2gFz61SgU6sEnQA692A7ADnoRho5E8eHPhxQRvUz6fKthcUCsWsbWACybyXcYVee7DkbRPBECB8vYvFyyYXXWK9GF7d02HwJ8uDdQy7AdgcdOP4TTR16l3N2+N7Z3mNhpiww2Jo5/CrMqbB9WeDlx7Gi3H/cyuq3n5EU4iYyE9Yjv5yCJzIaT561Il9sYC1+IwN4gPFhUt3x7Nf6x1dbT/IIQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 10 Jun 2026 07:31:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jun 08, 2026 at 06:31:08PM +0100, Andrew Cooper wrote:
> From: Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>
>
> xen.efi with debugging symbols is ~45MB, down to ~9.3MB when stripped.
> Multiple firmwares (as seen by QubesOS, Trenchboot, and XenServer) are unable
> to boot xen.efi when debugging symbols are included.
>
> Either way, having debug symbols by default is abnormal and contrary to how
> the non-EFI path works.
>
> Produce xen-syms.efi unconditionally, just like xen-syms. If
> CONFIG_DEBUG_INFO is enabled, these will contain debug symbols, and if not,
> then not. When xen-syms is processed by mkelf32, the debug symbols are simply
> discarded. For xen-syms.efi, call $(STRIP) to produce xen.efi.
>
> Some old versions of binutils ld managed to produce efi files which the
> matching version of strip couldn't process. This includes Binutils 2.26
> included in Ubuntu 16.04. Delete the workaround for this bug, and require a
> less broken toolchain.
>
> Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
