[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/4] scsi: use percpu counters for iostat counters in struct scsi_device
- To: Sumit Saxena <sumit.saxena@xxxxxxxxxxxx>, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
- From: Hannes Reinecke <hare@xxxxxxx>
- Date: Wed, 10 Jun 2026 08:21:07 +0200
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede2_rsa header.d=suse.de header.i="@suse.de" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References"; dkim=permerror header.s=susede2_ed25519 header.d=suse.de header.i="@suse.de"; dkim=pass header.s=susede2_rsa header.d=suse.de header.i="@suse.de" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References"; dkim=permerror header.s=susede2_ed25519 header.d=suse.de header.i="@suse.de"
- Authentication-results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="waHJe4W/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=U6EAtjYv
- Cc: "James E . J . Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Adam Radford <aradford@xxxxxxxxx>, Khalid Aziz <khalid@xxxxxxxxxxxxxx>, Adaptec OEM Raid Solutions <aacraid@xxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxxx>, "Juergen E . Fischer" <fischer@xxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Finn Thain <fthain@xxxxxxxxxxxxxx>, Michael Schmitz <schmitzmic@xxxxxxxxx>, Anil Gurumurthy <anil.gurumurthy@xxxxxxxxxx>, Sudarsana Kalluru <sudarsana.kalluru@xxxxxxxxxx>, Oliver Neukum <oliver@xxxxxxxxxx>, Ali Akcaagac <aliakc@xxxxxx>, Jamie Lenehan <lenehan@xxxxxxxxxxx>, Ram Vegesna <ram.vegesna@xxxxxxxxxxxx>, target-devel@xxxxxxxxxxxxxxx, Bradley Grove <linuxdrivers@xxxxxxxxxxxx>, Satish Kharat <satishkh@xxxxxxxxx>, Sesidhar Baddela <sebaddel@xxxxxxxxx>, Karan Tilak Kumar <kartilak@xxxxxxxxx>, Yihang Li <liyihang9@xxxxxxxxxxxxxx>, Don Brace <don.brace@xxxxxxxxxxxxx>, storagedev@xxxxxxxxxxxxx, HighPoint Linux Team <linux@xxxxxxxxxxxxxxxxxx>, Tyrel Datwyler <tyreld@xxxxxxxxxxxxx>, Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Christophe Leroy <chleroy@xxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, Brian King <brking@xxxxxxxxxx>, Lee Duncan <lduncan@xxxxxxxx>, Chris Leech <cleech@xxxxxxxxxx>, Mike Christie <michael.christie@xxxxxxxxxx>, open-iscsi@xxxxxxxxxxxxxxxx, Justin Tee <justin.tee@xxxxxxxxxxxx>, Paul Ely <paul.ely@xxxxxxxxxxxx>, Kashyap Desai <kashyap.desai@xxxxxxxxxxxx>, Shivasharan S <shivasharan.srikanteshwara@xxxxxxxxxxxx>, Chandrakanth Patil <chandrakanth.patil@xxxxxxxxxxxx>, megaraidlinux.pdl@xxxxxxxxxxxx, Sathya Prakash Veerichetty <sathya.prakash@xxxxxxxxxxxx>, Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxx>, mpi3mr-linuxdrv.pdl@xxxxxxxxxxxx, Suganath Prabu Subramani <suganath-prabu.subramani@xxxxxxxxxxxx>, Ranjan Kumar <ranjan.kumar@xxxxxxxxxxxx>, MPT-FusionLinux.pdl@xxxxxxxxxxxx, Daniel Palmer <daniel@xxxxxxxxx>, GOTO Masanori <gotom@xxxxxxxxxxxx>, YOKOTA Hiroshi <yokota@xxxxxxxxxxxxxxxxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>, Geoff Levand <geoff@xxxxxxxxxxxxx>, Michael Reed <mdr@xxxxxxx>, Nilesh Javali <njavali@xxxxxxxxxxx>, GR-QLogic-Storage-Upstream@xxxxxxxxxxx, Narsimhulu Musini <nmusini@xxxxxxxxx>, "K . Y . Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Long Li <longli@xxxxxxxxxxxxx>, linux-hyperv@xxxxxxxxxxxxxxx, "Michael S . Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Eugenio Perez <eperezma@xxxxxxxxxx>, virtualization@xxxxxxxxxxxxxxx, Vishal Bhakta <vishal.bhakta@xxxxxxxxxxxx>, bcm-kernel-feedback-list@xxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, John Garry <john.g.garry@xxxxxxxxxx>
- Delivery-date: Wed, 10 Jun 2026 06:21:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 6/9/26 14:18, Sumit Saxena wrote:
iorequest_cnt and iodone_cnt are updated on every command dispatch and
completion, often from different CPUs on high queue depth workloads.
Using adjacent atomic_t fields causes cache line contention between the
submission and completion paths.
Extend the same treatment to ioerr_cnt and iotmo_cnt so all four iostat
counters in struct scsi_device use struct percpu_counter.
Suggested-by: John Garry <john.g.garry@xxxxxxxxxx>
Signed-off-by: Sumit Saxena <sumit.saxena@xxxxxxxxxxxx>
---
drivers/scsi/scsi_error.c | 4 ++--
drivers/scsi/scsi_lib.c | 10 +++++-----
drivers/scsi/scsi_scan.c | 8 ++++++++
drivers/scsi/scsi_sysfs.c | 23 ++++++++++++++---------
drivers/scsi/sd.c | 2 +-
include/scsi/scsi_device.h | 9 +++++----
6 files changed, 35 insertions(+), 21 deletions(-)
Good idea.
Reviewed-by: Hannes Reinecke <hare@xxxxxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
|
