[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/4] block: drop shared-tag fairness throttling
- To: Sumit Saxena <sumit.saxena@xxxxxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Date: Tue, 9 Jun 2026 23:14:11 -0700
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=bombadil.20210309 header.d=infradead.org header.i="@infradead.org" header.h="In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date"
- Cc: "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, "James E . J . Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Adam Radford <aradford@xxxxxxxxx>, Khalid Aziz <khalid@xxxxxxxxxxxxxx>, Adaptec OEM Raid Solutions <aacraid@xxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxxx>, "Juergen E . Fischer" <fischer@xxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Finn Thain <fthain@xxxxxxxxxxxxxx>, Michael Schmitz <schmitzmic@xxxxxxxxx>, Anil Gurumurthy <anil.gurumurthy@xxxxxxxxxx>, Sudarsana Kalluru <sudarsana.kalluru@xxxxxxxxxx>, Oliver Neukum <oliver@xxxxxxxxxx>, Ali Akcaagac <aliakc@xxxxxx>, Jamie Lenehan <lenehan@xxxxxxxxxxx>, Ram Vegesna <ram.vegesna@xxxxxxxxxxxx>, target-devel@xxxxxxxxxxxxxxx, Bradley Grove <linuxdrivers@xxxxxxxxxxxx>, Satish Kharat <satishkh@xxxxxxxxx>, Sesidhar Baddela <sebaddel@xxxxxxxxx>, Karan Tilak Kumar <kartilak@xxxxxxxxx>, Yihang Li <liyihang9@xxxxxxxxxxxxxx>, Don Brace <don.brace@xxxxxxxxxxxxx>, storagedev@xxxxxxxxxxxxx, HighPoint Linux Team <linux@xxxxxxxxxxxxxxxxxx>, Tyrel Datwyler <tyreld@xxxxxxxxxxxxx>, Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Christophe Leroy <chleroy@xxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, Brian King <brking@xxxxxxxxxx>, Lee Duncan <lduncan@xxxxxxxx>, Chris Leech <cleech@xxxxxxxxxx>, Mike Christie <michael.christie@xxxxxxxxxx>, open-iscsi@xxxxxxxxxxxxxxxx, Justin Tee <justin.tee@xxxxxxxxxxxx>, Paul Ely <paul.ely@xxxxxxxxxxxx>, Kashyap Desai <kashyap.desai@xxxxxxxxxxxx>, Shivasharan S <shivasharan.srikanteshwara@xxxxxxxxxxxx>, Chandrakanth Patil <chandrakanth.patil@xxxxxxxxxxxx>, megaraidlinux.pdl@xxxxxxxxxxxx, Sathya Prakash Veerichetty <sathya.prakash@xxxxxxxxxxxx>, Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxx>, mpi3mr-linuxdrv.pdl@xxxxxxxxxxxx, Suganath Prabu Subramani <suganath-prabu.subramani@xxxxxxxxxxxx>, Ranjan Kumar <ranjan.kumar@xxxxxxxxxxxx>, MPT-FusionLinux.pdl@xxxxxxxxxxxx, Daniel Palmer <daniel@xxxxxxxxx>, GOTO Masanori <gotom@xxxxxxxxxxxx>, YOKOTA Hiroshi <yokota@xxxxxxxxxxxxxxxxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>, Geoff Levand <geoff@xxxxxxxxxxxxx>, Michael Reed <mdr@xxxxxxx>, Nilesh Javali <njavali@xxxxxxxxxxx>, GR-QLogic-Storage-Upstream@xxxxxxxxxxx, Narsimhulu Musini <nmusini@xxxxxxxxx>, "K . Y . Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Long Li <longli@xxxxxxxxxxxxx>, linux-hyperv@xxxxxxxxxxxxxxx, "Michael S . Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Eugenio Perez <eperezma@xxxxxxxxxx>, virtualization@xxxxxxxxxxxxxxx, Vishal Bhakta <vishal.bhakta@xxxxxxxxxxxx>, bcm-kernel-feedback-list@xxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Bart Van Assche <bvanassche@xxxxxxx>
- Delivery-date: Wed, 10 Jun 2026 06:17:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Just dropping the fairness was rejected before and there is no
explanation here on why any of that has changed.
On Tue, Jun 09, 2026 at 05:48:02PM +0530, Sumit Saxena wrote:
> From: Bart Van Assche <bvanassche@xxxxxxx>
>
> Original patch [1] by Bart Van Assche; this version is rebased onto the
> current tree. In testing it improves IOPS by roughly 16-18% by removing
> the fair-sharing throttle on shared tag queues.
>
> This patch removes the following code and structure members:
> - The function hctx_may_queue().
> - blk_mq_hw_ctx.nr_active and request_queue.nr_active_requests_shared_tags
> and also all the code that modifies these two member variables.
.. and besides that, this commit message is still entirely useless
as it doesn't explain any of the thoughts of why this change is safe
and desirable. While the mechanics above are totally obvious from
the code change itself.
|