Xen project Mailing List

[PATCH v6 1/3] ns16550: properly initialize booleans in uart_param[]

From: Jiaqing Zhao <Zhao.Jiaqing@xxxxxxx>

Date: Wed, 10 Jun 2026 13:40:28 +0800

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OiwUxfzZ52HOR4Og8Wmwymh6ekARcn9POkjVivbBbj8=; b=xUYLHc7UbIdkCztA79QMpJCge16EFdpSQv+Bc+Oi5hFD2cbxINTejjVb6X0sby+OBKpNdLyDXW+ak1H0gyoj67dJfmimsg6g29ybdMVCDxIxr+lNYdrFF40/OPkAmLJLvYsp+zb+k93C1G7v9Rgy3i9+Gx3GxwtLJZ0G/xYIClYKpUN6VpkvzzgD1mfm/snVP1E1WH+1IUaPKOz8uQ26jXV9S2TwN5gHLGqZ6MNMN1vsAPIYKdOZQ5ruB3aKjosPS1fP4ouIgGGAb97IcOAq7THg2t/z3ieIDF0GscmWLJAigj3jmOXYebux6Y2Gy29KF5of5KtYjRFMBGhwcS2QKQ==

Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xH45YQ8z9+LViXVqVrGnpiBGXYEUOot4CIhg9nAzAUtCov7snp6wUaASdYYM7tUnKHQ9dxlggdukR24aRdS6RY1dseH743GD0x1iZ6QKUvmLaTL4tZ3qn0xbHV9VGCVmJY5A/h1eg5GwnkV+0u3po6HHENORUtleDpuE6QLqpiEfJPJyrcSo5ql0ZI6GPxVi6ufP/Jms5fNkoERQuXOxwUlzwvVI6RSnFLBba1eyaQlKP9Dkmsd2JNOgZGU28QR2o9rDVDoCSD1bMfFf4kDCkC1zGIEBO5ROYXIgIeJG1XUOtQQfn0KMcp+fdyoElFra5yaLR2PgIngUGe6N0i6RGg==

Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"

Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Jiaqing Zhao <Zhao.Jiaqing@xxxxxxx>, Denis Mukhin <dmukhin@xxxxxxxx>

Delivery-date: Wed, 10 Jun 2026 05:41:08 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

.bar0 and .mmio in struct ns16550_config_param are booleans, hence they should be initialized with "true", not "1". No functional change. Signed-off-by: Jiaqing Zhao <Zhao.Jiaqing@xxxxxxx> Reviewed-by: Denis Mukhin <dmukhin@xxxxxxxx> Acked-by: Jan Beulich <jbeulich@xxxxxxxx> --- xen/drivers/char/ns16550.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 878da27f2e..ed4e29ec25 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -758,7 +758,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = (UART_LSR_THRE | UART_LSR_TEMT), - .mmio = 1, + .mmio = true, .max_ports = 1, }, [param_oxford] = { @@ -768,7 +768,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = UART_LSR_THRE, - .mmio = 1, + .mmio = true, .max_ports = 1, /* It can do more, but we would need more custom code.*/ }, [param_oxford_2port] = { @@ -778,7 +778,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = UART_LSR_THRE, - .mmio = 1, + .mmio = true, .max_ports = 2, }, [param_pericom_1port] = { @@ -787,7 +787,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, + .bar0 = true, .max_ports = 1, }, [param_pericom_2port] = { @@ -796,7 +796,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, + .bar0 = true, .max_ports = 2, }, /* @@ -809,7 +809,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, + .bar0 = true, .max_ports = 4, }, [param_pericom_8port] = { @@ -818,7 +818,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, + .bar0 = true, .max_ports = 8, }, [param_exar_xr17v352] = { @@ -827,8 +827,8 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 256, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, - .mmio = 1, + .bar0 = true, + .mmio = true, .max_ports = 2, }, [param_exar_xr17v354] = { @@ -837,8 +837,8 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 256, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, - .mmio = 1, + .bar0 = true, + .mmio = true, .max_ports = 4, }, [param_exar_xr17v358] = { @@ -847,8 +847,8 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 256, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, - .mmio = 1, + .bar0 = true, + .mmio = true, .max_ports = 8, }, [param_intel_lpss] = { @@ -857,8 +857,8 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 64, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, - .mmio = 1, + .bar0 = true, + .mmio = true, .max_ports = 1, }, }; -- 2.53.0

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.