[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 1/2] domctl: Handle XEN_DOMCTL_getpageframeinfo3 without the domctl lock
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Tue, 9 Jun 2026 16:15:27 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OCiYcjADFgsxAz71CoNGnpjlgnb+QtefvZ3g0STi4ko=; b=A7U6pjT4YvKJvMeMH/5Nyh8kQVEcZ7OpLlwX/xBIGTTRG3FfyiFPttl2qrx1Oos4DD2ZjE6ptppZi8FCas8CWuSg7GIxK21d4ExQMNQskzUcYT+plciSLi3F3WzmER7pMOMxLUtRKmk7e8coavJEzYyGXhQ8hDwbrMMPuHk7YmM5hOY6YPuG9Lp35NghjG380rwf3OlurvwuMgmVqnU9eDkydDym/lhKG66Wy49T3YEC4DjCsmhTEKITqLpYgRNLSQ1ogXdlDnipvhhFY6mPLxU4xBFLyS07epzEJeeaeAkNQOUQABKYrQcwPfn5LT3il5YZ6P/bxwXZ4aY18uLPAg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TVIPmI21Kgdk+ljPvBlSvT+0ax1gmDfqrQ5jA24cf5vZ7g9wkcK0ZA4hmkEsfcy/MMN8V1/mjiGitWS1HKWvfvrUikeeiC2+UNh943O+pMTe9ScFRWH7yUs9sphN0EFoWSz0nkLYFjNg2OrS8yqtiIQ1sBflTrDk2wUocqlBleQctvI1jYYRYbG4IVduBGLGmQ9TI+/rAM4UpntF1OsO0K5mIlU6ypLeqZ1ghnwOKWFTa3YDYDVk0dXotUXT20CD7WwECsPBEvCvnv/tSrmd8eDcH6C83A9Xy9GeOmATipd0YadPB3k4s/J7RQco0ofCJYF/MmMA0fy+RvtuU6uQfA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 09 Jun 2026 15:15:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
It does not have side effects and is protected from concurrent changes
by the P2M read lock therefore skip taking the domctl lock.
Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
---
xen/arch/x86/domctl.c | 4 ++++
xen/common/domctl.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index 83bf51e498df..0e9a2532887e 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -301,6 +301,10 @@ long arch_do_domctl(
/* Games to allow this code block to handle a compat guest. */
void __user *guest_handle = domctl->u.getpageframeinfo3.array.p;
+ ret = xsm_domctl(XSM_OTHER, d, domctl);
+ if ( ret )
+ break;
+
if ( unlikely(num > 1024) ||
unlikely(num != domctl->u.getpageframeinfo3.num) )
{
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 3efa5b9d55b9..35144d95b808 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -555,6 +555,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t)
u_domctl)
case XEN_DOMCTL_gsi_permission:
case XEN_DOMCTL_bind_pt_irq:
case XEN_DOMCTL_unbind_pt_irq:
+ case XEN_DOMCTL_getpageframeinfo3:
ret = arch_do_domctl(op, d, u_domctl);
goto domctl_out_unlock_domonly;
--
2.53.0
|
