[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.22] tools/ocaml: silence ocaml_deprecated_auto_include alert





On 6/9/26 10:24 AM, Andrew Cooper wrote:
On 09/06/2026 8:36 am, Guillaume Thouvenin wrote:
Ocaml's lib directory layout changed in 5.0: the unix and dynlink
libraries have been moved out of the standard library directory into
subdirectories. The compiler still locates them automatically but emits
an ocaml_deprecated_auto_include alert when doing so.

This patch sets the paths explicitly with -I +unix and -I +dynlink to
silence the alert.

Signed-off-by: Guillaume Thouvenin <guillaume.thouvenin@xxxxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

---
  tools/ocaml/common.make | 1 +
  1 file changed, 1 insertion(+)

diff --git a/tools/ocaml/common.make b/tools/ocaml/common.make
index c7eefceeb4..0e6714e25a 100644
--- a/tools/ocaml/common.make
+++ b/tools/ocaml/common.make
@@ -11,6 +11,7 @@ OCAMLFIND ?= ocamlfind
CFLAGS += -fPIC -I$(shell ocamlc -where) +OCAMLINCLUDE += -I +unix -I +dynlink
  OCAMLOPTFLAGS = -g -ccopt "$(LDFLAGS)" -dtypes $(OCAMLINCLUDE) -w F 
-warn-error F
  OCAMLCFLAGS += -g $(OCAMLINCLUDE) -w F -warn-error F

CC Oleksii.

For 4.22.  This fixes a build warning with newer versions of Ocaml, and
also wants backporting to older trees.

You just pinged me when I started to look at the patch.

It look okay for me to have in in 4.22:
 Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

Thanks.

~ Oleksii



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.