Re: [PATCH v3 5/6] argo: introduce CONFIG_ARGO_DEBUG

[dmukhin@xxxxxxxx]

On Mon, Jun 08, 2026 at 04:10:15PM -0400, Daniel P. Smith wrote:
> 
> 
> On 5/26/26 5:58 PM, dmukhin@xxxxxxxx wrote:
> > From: Denis Mukhin <dmukhin@xxxxxxxx>
> > 
> > Add Kconfig knob to enable traces for Argo debugging.
> > 
> > Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
> > ---
> > Changes since v2:
> > - new patch
> > ---
> >   xen/common/Kconfig | 7 +++++++
> >   xen/common/argo.c  | 3 +--
> >   2 files changed, 8 insertions(+), 2 deletions(-)
> > 
> > diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> > index 5ff71480eebe..adcdc51dd21b 100644
> > --- a/xen/common/Kconfig
> > +++ b/xen/common/Kconfig
> > @@ -491,6 +491,13 @@ config ARGO
> >       If unsure, say N.
> > +config ARGO_DEBUG
> > +   bool "Argo: enable debug traces (UNSUPPORTED)" if ARGO
> > +   help
> > +     Enables extra debug traces for Argo debugging.
> > +
> > +     If unsure, say N.
> > +
> >   source "common/sched/Kconfig"
> >   config CRYPTO
> > diff --git a/xen/common/argo.c b/xen/common/argo.c
> > index 3c38a51d09a2..b9b362064e7e 100644
> > --- a/xen/common/argo.c
> > +++ b/xen/common/argo.c
> > @@ -318,10 +318,9 @@ static DEFINE_RWLOCK(L1_global_argo_rwlock); /* L1 */
> >       ((LOCKING_Read_L1 && spin_is_locked(&(d)->argo->send_L2_lock)) || \
> >        LOCKING_Write_L1)
> > -#define ARGO_DEBUG 0
> >   #define argo_dprintk(fmt, args...)                      \
> >       do {                                                \
> > -        if ( ARGO_DEBUG )                               \
> > +        if ( IS_ENABLED(CONFIG_ARGO_DEBUG) )            \
> >               gprintk(XENLOG_DEBUG, "argo: " fmt, ##args);\
> >       } while ( 0 )
> 
> Is a Kconfig really desired here? This such a trivial knob and one that is
> really only intended for tuning by the developers. Exposing it as a Kconfig
> option means you intend for this to be tuned by distro builders and wanting
> to see it exercised by the CI RandConfig.

Yes, something like this: parameterized CI (local) build variants.

With Kconfig facility present it is simple to enable extra verbose debug
builds.

--
Denis