[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/16] libs/guest: allocate various migration arrays just once
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 8 Jun 2026 17:50:33 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dXlSkZFxGEFH2BV1lVRsWxoYVAPbMpGtmnx1z0ApjqE=; b=ib9c1MA0BDtB1FEOd/Ll6AUvMRn1GNmAgXU+cPtDY0Gc9ndrvxX5HMTRTQTgnufODVWfalAuWgce31kIJtbU+77zXPVRhbA+WsT7/N26c0ELZpWZVnkA33AHuH8podOnqkq8fmg9dJO6oGWBshFUjMb2goibEei8/oFTCVQnn2CwMj6c9tGduRnVfG22nX2br07fUlhYapFAyt8GpNoAfT0UckQR0QmEwbDumVScBfB3AbltdJzibgmGsji7rhSMrGGrTPtLK56CDFLbTbVpvcvdHF/RZysK28tJilMo/q5Ep8EOxmQqFcrit9SoSu1XXkn7UDUPoV5jaXNG+iLArQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xONYVXs7J1uREFNrOuQNH71piK2u7ajACkKgRqqkw4V29cNtZm2OhegGN+pcIjadZfPtsyVffMvqXd3RXgDGn/NlQww69bYD9LuhW6NI5fvbiq97Td79PXc7rtNZT5iQ0nIsLJw6rYPYeM5VjvUuRkYeieWWaRpqV+mIz81iW/a7B2gL2EiGU81I4IvukLHygZaP0P+vzTfhPWaTJmzWLoU4vhYa+UJ0rCBgwNcvtRHGUFN2e2SJbKypWREesSl4P8HWnWsrvtYGz0xMiw6WqJ29HOUizkCz0H6FjNA1Yg0jQ+B0x+ZKtyQNdo8rLkdQ91z61LG5EYQt1HhIy0ntEw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Frediano Ziglio <freddy77@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Edwin Török <edwin.torok@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>
- Delivery-date: Mon, 08 Jun 2026 15:50:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jun 08, 2026 at 04:36:54PM +0100, Andrew Cooper wrote:
> On 03/06/2026 2:05 pm, Frediano Ziglio wrote:
> > From: Edwin Török <edwin.torok@xxxxxxxxxx>
> >
> > Allocate these array just once at the start of migration,
> > using the maximum batch size, and free them at the end.
> >
> > Signed-off-by: Edwin Török <edwin.torok@xxxxxxxxxx>
> > Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>
> > --
> > Changes since v2:
> > - change prefix in subject.
> >
> > Changes since v3:
> > - fix comment style
>
> These are intentionally freed/reallocated so valgrind can find overflows.
Hm, then we likely need to keep the current behavior for CONFIG_DEBUG
builds of the library?
Thanks, Roger.
|
