Re: [PATCH for-4.22(?) 0/2] tools: Use the system liblz4 package

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 6/8/26 12:57 PM, Andrew Cooper wrote:
> On 08/06/2026 11:51 am, Oleksii Kurochko wrote:
> > On 6/3/26 3:01 PM, Oleksii Kurochko wrote:
> > > On 6/3/26 11:16 AM, Jan Beulich wrote:
> > > > On 03.06.2026 10:53, Andrew Cooper wrote:
> > > > > Switch to using the system liblz4.
> > > > >
> > > > > This brings libxenguest's lz4 decompression in line all the others,
> > > > > rather
> > > > > than using the unsafe decompressor from Xen (itself a port of
> > > > > Linux's unsafe
> > > > > decompressor).
> > > Generally, the patch series looks straightforward and low risk, so I
> > > am comfortable taking it for this release. Considering that...
> > >
> > > > As stated in 84f04d8f0dbf ("libxc: add LZ4 decompression support"),
> > > > there was
> > > > no shared library available at the time (and on the SLES versions I
> > > > worked
> > > > with). Later a shared library appeared, but the -devel package still
> > > > wasn't
> > > > there. On my main dev system (intentionally a relatively old SLES
> > > > version) I
> > > > therefore wouldn't be able to build/test LZ4 anymore if we went this
> > > > route.
> > > > (FTAOD this isn't an outright objection, as the goal of the series is
> > > > certainly good. It is mainly a data point to consider.)
> > > ...does not consider this an outright objection. While this may
> > > become an issue sooner or later on older dev systems, if the change
> > > is accepted into staging, we could switch to the shared library
> > > approach in 4.22.
> > Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> I've included this incremental diff for CHANGELOG.
>
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index 1db3efc4864c..5cf19372a361 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -13,6 +13,7 @@ The format is based on [Keep a 
> Changelog](https://keepachangelog.com/en/1.0.0/)
>      represent a wildcard input.
>    - On x86:
>      - Enable pf-fixup option by default for PVH dom0.
> +   - The libxenguest bzImage loader now uses the system liblz4 library.
Looks good to me.

Thanks.

~ Oleksii