[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 1/3] xen/x86: Remove unneeded stub_page setting


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Thu, 4 Jun 2026 19:18:35 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W9jLJUo0KRF9a1Emi4WUAg1Yr2QpnkFjH6PBbQy5L6w=; b=Ge7CgrQ6jue31mAuWpzWS/UGifhhb3sFtb4f8XMOZV9bkyF296dUbyxgBAtDanMUddghx93kM23DeQYGz+eDqFZW4ulKqVSCh/MbHnxLI1LtQ/5ld8GovNjms/cds1vc2azsSOs0OszYMntKtuM60TNrrdfeqesyxCIBSLt02Vj6tgJkKotLVb2k7e/S52cHWSalJX+Z3q0HtR4qTAtx0ArlllFEiTD9D/iSUrNgs9yTnFgidsoGPd1Z2WO6LSl6YFYcIGcZfwijmpSq6p39xbMRVGLQdUsPAdWk9bKIza+ld0cR5LNnBE9wK3+GhKlDMiexfTwVspYbLunBlrmeWQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=osmmaSnh/GWPUxySpk2Ml6g9LOoMBKN7JRiTPSkdWkPJuqf0PL8TjAXljE1ZFVcLZF1VgIvmzLmJE8sitd6+DvE+OmYN/hYI78PQxtl9+WFGIdQn2CKXgmOXrVsn93UQaQ8nm9BsiOdoIf9JwjfnmV8G5BhM+Ge//q+Fira9sgPbcFddhcVgDUYATkvoc5OudHXgDrkIR5nW72iqPtI5y1au3ZHDcLmRbUpKXL2SGHYOUQ75OIidjc/bs+W8jEIzHAyyK9bONKlDRhfH9VGeMBdMtI8j9t175lPik4DKTyMSisRVxP9o+AyENn3sCqR80MPIPUY6KFPUMNpzwB5i2w==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: Jason Andryuk <jason.andryuk@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
  • Delivery-date: Thu, 04 Jun 2026 23:52:13 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

stub_page is not used in the for loop, and it unconditionally set below
just outside the patch context with:
    stub_page = alloc_stub_page(cpu, &per_cpu(stubs.mfn, cpu));

Remove it.

Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
---
 xen/arch/x86/smpboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index ff05955bae..7241dba621 100644
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -1091,7 +1091,7 @@ static int cpu_smpboot_alloc(unsigned int cpu)
     memcpy(per_cpu(idt, cpu), bsp_idt, sizeof(bsp_idt));
     disable_each_ist(per_cpu(idt, cpu));
 
-    for ( stub_page = 0, i = cpu & ~(STUBS_PER_PAGE - 1);
+    for ( i = cpu & ~(STUBS_PER_PAGE - 1);
           i < nr_cpu_ids && i <= (cpu | (STUBS_PER_PAGE - 1)); ++i )
         if ( cpu_online(i) && cpu_to_node(i) == node )
         {
-- 
2.54.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.