Re: [PATCH 3/6] x86/efi: discard .text.header for PE binary

[Frediano Ziglio <freddy77@xxxxxxxxx>]

On Thu, 4 Jun 2026 at 15:31, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 04/06/2026 11:28 am, Frediano Ziglio wrote:
> > On Tue, 2 Jun 2026 at 13:15, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> >>> --- a/xen/arch/x86/xen.lds.S
> >>> +++ b/xen/arch/x86/xen.lds.S
> >>> @@ -57,6 +57,9 @@ SECTIONS
> >>>    __image_base__ = .;
> >>>  #else
> >>>    . = __image_base__;
> >>> +  /DISCARD/ : {
> >>> +    *(.text.header)
> >>> +  }
> >>>  #endif
> >> We already have DISCARD_SECTIONS, so I think it needs clarifying why that
> >> can't be used / extended.
> >>
> > Yes, this can be done that way. Roger, do you agree on this ?
>
> You'll need to add a general ARCH_DISCARD_SECTIONS, and have x86 fill in
> {ELF,EFI}_DISCARD_SECTIONS conditionally.
>

I think binutils simply ignore sections not present so this is not
necessary. I'll test it.

> Also you need to fold this hunk.
>
> diff --git a/docs/hypervisor-guide/x86/how-xen-boots.rst 
> b/docs/hypervisor-guide/x86/how-xen-boots.rst
> index 8b3229005cca..b6d852050a0c 100644
> --- a/docs/hypervisor-guide/x86/how-xen-boots.rst
> +++ b/docs/hypervisor-guide/x86/how-xen-boots.rst
> @@ -82,12 +82,6 @@ When a PEI-capable toolchain is found, the objects are 
> linked together and a
>  PE32+ binary is created.  It can be run directly from the EFI shell, and has
>  ``efi_start`` as its entry symbol.
>
> -.. note::
> -
> -   xen.efi does contain all MB1/MB2/PVH tags included in the rest of the
> -   build.  However, entry via anything other than the EFI64 protocol is
> -   unsupported, and won't work.
> -
>
>  Boot
>  ----
>

Sure, thanks

>
>
> ~Andrew

Frediano