[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/6] x86/efi: discard multiboot related entry code for PE binary
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Frediano Ziglio <freddy77@xxxxxxxxx>
- Date: Thu, 4 Jun 2026 11:32:09 +0100
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=kTVs0z6F28EiA5vbr0oEiu4LOa8D6Q2SwnuB/7vzbwA=; fh=hLlsiwH23pAKb3EaW5nccT+0+LH92H+BDVsLIMBghTg=; b=TrkJitPrDcRROsCCs8vpWz0Zby/EMGoem9yAOYh15wLS6JCgbCEHOqhiycjJj4jabV LrfpVJWz1EUc2AfgA+SHwr0dZkHcUSBTvFUiSTzf06pBzRFyuH7hXa/ogdDNZ/W45Vj3 MGdsF2bRDlQv88p5ThOE8I4PCVwYcHpfOkDnaXwr5Cp/Yq97YUtzNangO9PF2/CMOtyv 2O+WyPHh5Suud/dZojvuatWjT3d9bWLJTRmyWQOyUsNCa9VC7WDQlG+Pm0e5ApCmxsL1 mLMdG6P2FQJsdijQ3tg7WnhT5MFpm4oAt9fln75qzbGEM1/CUgHhvZGeWYGdcMUtvRfd oDyw==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1780569141; cv=none; d=google.com; s=arc-20240605; b=Uy88MsEmqy8oQpAAH0neL5XVip3wFLQnfYFFUu4MeWc8wxaHTVqd8Bx858rIPox3oN IWwWtV5EWw4PkkVXIe46YCNywulsnVT/clqE2sm92L4jPqPtc0qeOmJKHaWXEpYDiFRY 06g/5v5HAUyGiFXYl62GT6jA2CBgkabgZcidyYcX3VDY8W6jiBp0imwhSI1vcv1IjazH 3Ihw9SZUvsSI3OcZPdF+qDFHKCfHR1e9Es43pvpLxloE26jDZglijt0eCkuhWAGcQwmZ fUHyYyzt5cNmqmeGBzTPym6mSFndRD+Ar8SQ+UsFO7QdQel7Hr0FsNXE5kxE8zeECHRb qr4w==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 04 Jun 2026 10:32:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, 2 Jun 2026 at 13:17, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 29.05.2026 17:35, Frediano Ziglio wrote:
> > From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> >
> > The multiboot and PVH entry points are not used in the PE binary, hence
> > discard them in the linker script when doing a PE build.
> >
> > That removes some relocations that otherwise appear due to the entry point
> > code in head.S not being position independent.
> >
> > No functional change intended.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > xen/arch/x86/boot/head.S | 3 ++-
> > xen/arch/x86/xen.lds.S | 2 ++
> > 2 files changed, 4 insertions(+), 1 deletion(-)
>
> S-o-b issue again.
>
Even if I didn't make any changes to the original patch ?
> > @@ -200,6 +201,7 @@ SECTIONS
> > _sinittext = .;
> > *(.init.text)
> > *(.text.startup)
> > + *(.init.multiboot)
> > _einittext = .;
>
> Aren't you making a needlessly big change to the final image by placing this
> last rather than first?
>
Yes, I agree, .init.multiboot section should be even before
.init.test. I'll change it.
> Jan
Frediano
|
