[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] x86/MCE: adjust ID2COOKIE() for Misra C:2012 rule 11.2
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Mon, 18 May 2026 16:35:59 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1779114960; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=5kvEkR+x1Zrs5LIJVh7DFk9j7lKLX5Qk/Ynk9sx/Yr8=; b=qJF95nK1lyw3CCtxA5XxlNHQHiAMsG5wTfy62HI10HtqyYpjA1t/bAegUF86yhfw3vD2 Ky6x3Lw2Zenb+okYHaaNTTSXkIWHRoifeOnt5beVPlRR93UIZEEMk1k+XrNmdyFgQ4spE 2da/DAsTUIvkSPYpQaKpCsTstZjoGBLOB1jNoxzzTSKNoyuCQ5lXoG5oXEdnnCE7knCEt Gef9egb6pbnT1YZPoi9dfI2QL9hR/Tfg3nSoF7meNz7vMNZt5OLiq1IPFGW6iDu768sYm 2IoEV+nTgDAqoSkr1Ec3ufk+rWQtpAZ8KJsYPSo6S1xwwYHEnBt019rIsQvBuMMkmidNj K4ItOEnTvufsDPG1zDD1Z6h8gTIaw/qD1WfcgL8IkayFlas7O1v1Gk6cpv614SLdkbjOe HXuWELdBqGLIThbENmVeO7sBzwqtxbyoNNpswyBJeGMxCCFQz3RLSJp5i46pip/gisJLj 5kdTpPDHAis8FyvB2sIgo69csaN6nqpif5bOLlfeM6TGPP9+hq0v8eeHygWPkTUYLL3aH mexYchmXLk6lXl3R284RhLKydCUMMnBALV0Dp7W9yHZXr8i9Sz87S/VjnYpgv3xCVcmHk +bfNdmviC+73z07rOkMNpYjhEMdWF8ghv5IiZ1/MUjt+eX27hqSZ90B5s0YROTE=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1779114960; b=mBVM5EVKupG5nuvs6O2D3qHJGff4FZm2LKTSBzFho6I0/eqV3dEiVmqkL4Ne9w9EWfxJ RGKgZKtzH1baJTtfMikZMjYns+dxe7g8XAyZSpEWLjlQeuTtkaIBlkE2E1gIW4gJBGeN+ XR8mURFsR/+bJIExSJXkSBlJ2oAMMaZU41oTC8rgXYRBBzcdZtcd+L4tpVMmbr1WezKbF 5KigB2RAicQaBTVv3s+E8mwxNzeeEjFP+cAT9+fYVboD6lijbqbiHVvmGX83NYCeNtzjO eD5PmsgY/ZcknMUYOJdBAPAO4WUeAALPZD6A/7VBHA/5+yNjq11VTsdvX3XJ++u/ldlhW yd1EHuyeAovCuo+6aghhXAhVom5+9EGPEfulf2Pm5HtiCAVZPv8l9jbzIOiDtDZKgaZxk eSBI0vPxA9Z4FB3mZYA4V9lgUeVH2vKvBabByvHOqDnEmF6sdyvx63YNnPA+/IWcT6Vt2 F7+m5PlFAFyNkVMHy0LXlVQjYpLBfrBOm1GRnqKaMrwU6Mo0ZX5E4AVmCAgVyjMaDFtli SxvigNrnJRbZSwJ4+2eoYFiJXrNPH9AMfFq4Tnsr2QCLGngAWClM9iFx+KGtHGM9GZ2I+ qdYDby6/iGn1e/2wf2eT7zoVS+fFp7qZrcxaWhjavl3JOXDY80iXEcyTNY2P+Iw=
- Authentication-results: eu.smtp.expurgate.cloud; none
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
- Delivery-date: Mon, 18 May 2026 14:36:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-05-18 11:51, Jan Beulich wrote:
... ("Conversions shall not be performed between a pointer to an
incomplete type and any other type"): Add an intermediate cast to
unsigned long.
Stale comment I presume.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
v2: Add comment.
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -1264,7 +1264,8 @@ static void cf_check __maybe_unused x86_
#if BITS_PER_LONG == 64
-#define ID2COOKIE(id) ((mctelem_cookie_t)(id))
+/* Two layers of casting to cover Misra C:2012 rule 11.2. */
+#define ID2COOKIE(id) ((mctelem_cookie_t)(void *)(id))
#define COOKIE2ID(c) ((uint64_t)(c))
#elif defined(BITS_PER_LONG)
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
