[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/xenpm: fix FreeBSD build
- To: Teddy Astie <teddy.astie@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 21 Apr 2026 18:00:26 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HcuE4DhWVgFQwYKSSn/LhiSzXgWL0NKT55XH9CJAbWQ=; b=i3k0T2SKLi01PYxYF/F81rrH7TH+c8NuIcRmfqGVQD+xox5hcTCmQ+bQChHiYrzKzDnQFVTSB5zYMCXBmiHdTS84UPvIsfZOlhciRd73oh9dTHo/t1KP74Fh5RBizbrNm9WU3pXToty875w2mt8TvoExPxIc5Ukjz9pZ2XDE6OTYbWbJj18PW5knOQht4ENVVZraUsNNclyaOHN6L7HPhG9rKKSASgDKE8TgRAiS6jwb5vhHlJidu8iHg5x5LJK4MdteiY6SRML/ID2tGxaJByStBqbFTVrEiESAb2QlBFfDbrVmmwPqfQguESsJyDQirVpbN7LtdaUXtsh4xqAYdg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PUn+o14qziw57VsQPhhN3jzr+lmLSkuQ6HXNAnxL7tFMY/qh8ffFfDc84P6j6ira3R9Br4gMaexkfo30ZS4RX+QLQVUIcwhoHBKRKGJCnF8wl5wtqV5vU0Fjcq+54uHa0lR5kHg/HWh+atfICh1xqLqTRzuGhlRRL3/1mjZ/xF5diAWmH3LTGKWAD48uSiU0q43saMWq+PF3cEgslaR/bStwFblUnR/zff5cLyg3PHWy/Rrnhi4j55X/JGdqTQM50U2HtGJdC3xgrSEwK4+LmNaMacnA1yMLONJxy9OA1KwDliYWGV6esaVAOSWwYm+ZxA8k+epMQNY4VAZlOZRfIw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 21 Apr 2026 16:00:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Apr 21, 2026 at 05:58:02PM +0200, Teddy Astie wrote:
> Le 21/04/2026 à 17:36, Roger Pau Monne a écrit :
> > ENODATA is not defined on FreeBSD:
> >
> > xenpm.c:1380:17: error: use of undeclared identifier 'ENODATA'
> > 1380 | errno = ENODATA;
> > | ^
> > 1 error generated.
> >
> > Fixes: edb657887a60 ("xenpm: Add get-core-temp subcommand")
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > tools/misc/xenpm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c
> > index 87107bd6c617..ecb39c911d84 100644
> > --- a/tools/misc/xenpm.c
> > +++ b/tools/misc/xenpm.c
> > @@ -1377,7 +1377,7 @@ static int fetch_dts_temp(xc_interface *xch, uint32_t
> > cpu, bool package, int *te
> > {
> > case 0:
> > /* This CPU isn't online or can't query this MSR */
> > - errno = ENODATA;
> > + errno = ENODEV;
> > return -1;
> >
> > case 1:
>
> I wasn't aware ENODATA wasn't available on some BSDs. Even though it's
> supposed to be a part of POSIX.
Not in the last version I think?
https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/errno.h.html
Regards, Roger.
|
