[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/4] tools/tests/alloc: Unit and Integration Test Framework for page_alloc.c
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bernhard Kaindl <bernhard.kaindl@xxxxxxxxxx>
- Date: Sat, 18 Apr 2026 17:11:15 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Afwbcq+12hEaHn7NZlYlJDax7EJaA6PgpiZ9Oh2qgg8=; b=Da459KAnRztAzEzQazvQBYyX2D5VnGI0UgVdmKGFBqf0bbbwMsr8Pz2d5/8BIQKmeEzViln0H9+XNoYI2bLBYnTp6nvR0l+Vcrx9qEPcB5xpTeWzTQWatsb1hyNySz/HSl8j9SYAeJJ0knW6w2osWaPnWWkVjml6zPvkMd5rMWhK8KXZvM0282Qa86408L4XePA14SZt7tl+SGh1hC/xjcI26390tUdLeFtzWMainLhMPxJWtgH6Y0eDA+vK34j4xTeTV+yyIQXqguqP5J1qwW7VXvtO32j6edKktfRB2Rbl3uz/FLj3JL7in0g9gBpe7/K9+4y4wa6iVevyBpBDQw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=reIPMoSYwyR+vXWlGX0tm7dhgeuq8VsMWYsTrAx4GDGuXVINYYII3taYA5vEmFXkx6v+skVRmZgRzrM77sNqmL/NzaU+qaDfoRwa0wHW7210tJZwkiOAKCRJSDxoaiRuLnjFlfJ3uCpWVLrylyOCAN1TBBzK247+rAXVEspc/tpj2n+RxEI/LcRFFFOGZ6x0yrQmwoo8tiRongZzWoxWMEBYgTx8C95ADcUnrx6XWZdVLnw5H6XTuEKa91IPhLTvjdBG3Vn7ZjUJ9QUDUnsJ5mePDLwz4mzhAVOuPqtybYOjI8/nQFy9/gTESl5QMp9fXPsHwCPoAeygRHnZX2L41g==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Sat, 18 Apr 2026 17:11:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHczP/wsJouZWgAtUaG6dmfkksoe7XhTlkAgAO9yqA=
- Thread-topic: [PATCH 1/4] tools/tests/alloc: Unit and Integration Test Framework for page_alloc.c
> > Add a test framefork for unit and integration test suites testing
> > the Xen page allocator module xen/common/page_alloc.c in isolation.
> Just two remarks (nits?) for now:
[...]
> > tools/tests/alloc/hypervisor-macros.h | 101 ++++++
> > tools/tests/alloc/libtest-page_alloc.h | 356 +++++++++++++++++++
> > tools/tests/alloc/mock-page_list.h | 307 ++++++++++++++++
> > tools/tests/alloc/page_alloc-wrapper.h | 465 +++++++++++++++++++++++++
> > tools/tests/alloc/page_alloc_shim.h | 433 +++++++++++++++++++++++
> > 11 files changed, 2257 insertions(+)
>
> This is a lot of new code.
Ack, improved for v2. It will be reduced to 1411 lines, 60% smaller.
Changes for v2:
1. Refactor the test environment for minimalism:
- Improve separation of concerns.
- Move extensions to later patch series.
- Simplify code with targeted assertions and concise comments.
2. Fix file names to avoid underscores.
3. Update the include guards to comply with CODING_STYLE.
Bernhard
|
