[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v10] xenpm: Add get-core-temp subcommand


  • To: "Teddy Astie" <teddy.astie@xxxxxxxxxx>
  • From: "Anthony PERARD" <anthony.perard@xxxxxxxxxx>
  • Date: Fri, 17 Apr 2026 08:57:37 +0000
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=mte1 header.d=mandrillapp.com header.i="@mandrillapp.com" header.h="From:Subject:To:Cc:Message-Id:References:In-Reply-To:Feedback-ID:Date:MIME-Version:Content-Type:Content-Transfer-Encoding"; dkim=pass header.s=mte1 header.d=vates.tech header.i="anthony.perard@xxxxxxxxxx" header.h="From:Subject:To:Cc:Message-Id:References:In-Reply-To:Feedback-ID:Date:MIME-Version:Content-Type:Content-Transfer-Encoding"
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, "Oleksii Kurochko" <oleksii.kurochko@xxxxxxxxx>, "Community Manager" <community.manager@xxxxxxxxxxxxxx>
  • Delivery-date: Fri, 17 Apr 2026 08:57:47 +0000
  • Feedback-id: 30504962:30504962.20260417:md
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Apr 07, 2026 at 02:10:37PM +0000, Teddy Astie wrote:
> +    for ( cpu = 0; cpu < max_cpu_nr; cpu += physinfo.threads_per_core )
> +    {
> +        if ( fetch_dts_temp(xc_handle, cpu, false, &temp) )
> +        {
> +            fprintf(stderr, "[CPU%d] Unable to fetch temperature (%d - 
> %s)\n",
> +                    cpu, errno, strerror(errno));
> +            continue;
> +        }
> +

A trailing whitespace was introduced here since v9.

> +        has_data = true;
> +        printf("CPU%d: %d°C\n", cpu, temp);
> +    }

Beside that, patch looks good to me now:
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,


--
 | Vates

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.