[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/HPET: channel handling in hpet_broadcast_resume()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 16 Apr 2026 10:38:24 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cQS/bSQTrEiMEaBqkwPnFERmOVSRIH2DGttx4rqn7I8=; b=fQ1Ue5vNgi/bRVSvM+d5rRj0ygy1Ese87lD1RguOzgqNV2h1UaT5tPNMD6stg9gwEmHqybOoeOK5LIzjJnvdpiTfN5pL9YY5/2EgSiNnD2Lb7mB+JLyiE+s6gTHXt/ppx1m5nxdLcV/ceXXuhzGZP4iGysisULIgNuMQpDnHSNCQ+2sTixLebKXcjhxZOXgCtQORwMHe++3hcKCOWJOXq5kF1+GZ5gE+x6UgJA57AKcRhPRVVIgcTztiFNbiCmoWWvrw5pWV1TzmXdgCCe1vO20N4JgmEHkM2rIBfgzINFvFeHBu0d2bItXaxS9tG/MohY3uLZ8FoBuN6K2XWKDDcw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DfFeeNEQmvwIGJmeel1755e+pvqdqs4zLgkkvuVCYrIVqQfQxFfvrqHIMLfzVpKePEyKTnl5MXKOij8Hx9uJbEImMHI225lLuUm45HYOAnRdRzMGWzvlQd/mZYNgAMWee1hBRk3AG+GAUdKuIQWAXD9fpKRs4KmthToly7xpTLKnb+q09wKAfb7moEViojcVdVivpzJASZSW0jUot18nmv0azZUtwWu1O4/XIyRGPYR2HNsGET1DOXTTgdnxcb093+d/+8lF/gPce2Dg53G7x4snM3VZ3P99PJgCucXfeAXJWcxejs5M8ZaqxL+4Q1tWWJBbEU3/3wrxtKjncgWmnQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Marek Marczykowski <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 16 Apr 2026 08:38:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Apr 07, 2026 at 03:33:12PM +0200, Jan Beulich wrote:
> The per-channel ENABLE bit is to solely be driven by hpet_enable_channel()
> and hpet_msi_{,un}mask(). It doesn't need setting immediately. Except for
> the (possible) channel put in legacy mode we don't do so during boot
> either.
>
> Instead reset ->arch.cpu_mask, to avoid msi_compose_msg() yielding an
> all-zero message (when the passed in CPU mask has no online CPUs). Nothing
> would later call msi_compose_msg() / hpet_msi_write(), and hence nothing
> would later produce a well-formed message template in
> hpet_events[].msi.msg.
>
> Fixes: 15aa6c67486c ("amd iommu: use base platform MSI implementation")
> Reported-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Tested-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
I think you can adjust the now redundant irq_to_desc() to use dist as
Teddy noted?
Thanks, Roger.
|
