[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/lib: Introduce SHA-1
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 1 Dec 2025 14:19:16 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DrPiG4g47fZrVfZHKt1No8nMNfrWSmlFY2AjhxLv/EQ=; b=dbnJaWYJY0YdZm+Fp2FgvetRZdMJcsNSVlYe5b5QbENybCJqwVs53V9JhBVMi0U4tIBRxp/jbfwi9I9AdO3kwAgWjHtSdweBjeicxUmsR4/6KqNeeDt3Cq0ISI0XlKdCMpLxf4sSAHxRtlad18WCZkyt6rUemUjRH/x7mH/3GEbbc69DD9pBkgfWl1AzdWmYSSnCBDY8HlT71LfO+twnEXL0T14p0hZsPyPE8J4ATledq9veHDxk+PfsmGz8t5xA23XeR+RPm42XIX6GFkuLKKlBG5RxUZzqG1MYr1XlqSlATT3cyQEzkpUc6WdbGo574Ajt5gtazHJr3pz1l0OEZw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UHmxpafdaO7y5d2mmVNdCTqpS0Cf4dUO+7XZNUZRtgoO+qfqjYRGOMYuobRAATTDS2X8na/19CFRDgMEUKETtyu+NRQnslCNuavynondVItqN4Ty9yO1U7cLtoU9tPTwq7hPv7Gyk1tmP4dmXssWptIpmjj6zWaN+uzVzaIlDBkfXnpHvlV7k1mht/aQfBkQs/4MHRgxI9GtRq6DOo15mPaPHYuZpo3pTkxGcHtlQ5VqOi3Ier7DUzpwhai/SKt3WoaqDBIAGuPShKqc5qJRDVsmaGXDe1c9pTOudNt9LsUuVzyigdZzH9cjML/flncPsXmyfgcL215DTSlJm+rRgA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: andrew.cooper3@xxxxxxxxxx, Krystian Hebel <krystian.hebel@xxxxxxxxx>, Sergii Dmytruk <sergii.dmytruk@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 01 Dec 2025 14:19:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01/12/2025 8:46 am, Jan Beulich wrote:
> On 28.11.2025 19:47, Andrew Cooper wrote:
>> --- a/xen/lib/Makefile
>> +++ b/xen/lib/Makefile
>> @@ -17,6 +17,7 @@ lib-y += memset.o
>> lib-y += muldiv64.o
>> lib-y += parse-size.o
>> lib-y += rbtree.o
>> +lib-$(CONFIG_X86) += sha1.o
>> lib-$(CONFIG_X86) += sha2-256.o
>> lib-y += sort.o
>> lib-y += strcasecmp.o
> Why exactly are we confining the two SHA<n> to x86? They're both plain C
> implementations, so ought to be fine to build everywhere. Being in $(lib-y)
> they also wouldn't make it into the final binary until a reference would
> appear.
For the SHA2 patch, an objection was made to compiling it on the other
architectures. Personally I think they ought to be plain lib-y.
I could always have patch 1 fix up to lib-y and have patch 2 match...
~Andrew
|
