[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] hw/nvram/xlnx-bbram: More idiomatic and simpler error reporting
- To: Markus Armbruster <armbru@xxxxxxxxxx>
- From: Peter Xu <peterx@xxxxxxxxxx>
- Date: Wed, 19 Nov 2025 13:09:24 -0500
- Cc: qemu-devel@xxxxxxxxxx, kwolf@xxxxxxxxxx, hreitz@xxxxxxxxxx, mst@xxxxxxxxxx, imammedo@xxxxxxxxxx, anisinha@xxxxxxxxxx, gengdongjiu1@xxxxxxxxx, peter.maydell@xxxxxxxxxx, alistair@xxxxxxxxxxxxx, edgar.iglesias@xxxxxxxxx, npiggin@xxxxxxxxx, harshpb@xxxxxxxxxxxxx, palmer@xxxxxxxxxxx, liwei1518@xxxxxxxxx, dbarboza@xxxxxxxxxxxxxxxx, zhiwei_liu@xxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, anthony@xxxxxxxxxxxxxx, paul@xxxxxxx, berrange@xxxxxxxxxx, farosas@xxxxxxx, eblake@xxxxxxxxxx, vsementsov@xxxxxxxxxxxxxx, eduardo@xxxxxxxxxxx, marcel.apfelbaum@xxxxxxxxx, philmd@xxxxxxxxxx, wangyanan55@xxxxxxxxxx, zhao1.liu@xxxxxxxxx, qemu-block@xxxxxxxxxx, qemu-arm@xxxxxxxxxx, qemu-ppc@xxxxxxxxxx, qemu-riscv@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 19 Nov 2025 18:09:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Nov 19, 2025 at 02:08:52PM +0100, Markus Armbruster wrote:
> bbram_bdrv_error() interpolates a "detail" string into a template with
> error_setg_errno(), then reports the result with error_report().
> Produces error messages with an unwanted '.':
>
> BLK-NAME: BBRAM backstore DETAIL failed.: STERROR
>
> Replace both calls of bbram_bdrv_error() by straightforward
> error_report(), and drop the function. This is less code, easier to
> read, and the error message is more greppable.
>
> Also delete the unwanted '.'.
>
> Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx>
Reviewed-by: Peter Xu <peterx@xxxxxxxxxx>
--
Peter Xu
|
