[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] error: Consistently name Error * objects err, and not errp
- To: Markus Armbruster <armbru@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 19 Nov 2025 13:22:06 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aihNnCGI4tJ8zoQ72ytyPTqMzPj/HcLyikTFHTHi3gQ=; b=ZgVQ+WUBwwrvMNqTgUeIfuXJ3QnbJMU4jdomOmpcThYGLMBNOj1xYyB9cZsXSu1FRcLswrCW+pgeR02pNJjyUmgQxRebGxkW7P9x3hZBBuGeQdjQMQ2v9aVGrdSpOoAZlaitF1CvS38DLjsNi8zSRlm6ab2xs0Na/mpjIPjH1E9hlbNYV6ECnXXWyFUBpoHFww3z8Vgmn3H5E2mM1QhiLrKtTkP+cEvHBzWVnrNOvSZ6asJvV2spckxPvAQRf2wJ84YwBv+zINGVxYif/gwUXlyDkEwB8DU09q3MSf9/Fb9b8tzk3t0649aOWsDCQYsKCqYFNITkXXNvyE4hJrOqNw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eEJp9XEX0TQZpIkFqLFwpHhqXQC11rYrLDNvxjrZ64gGa2t54Ebcje0mcWHQl1rPJFasQNT4rVz0paOsgY5fVlbmVCnembpug7+bEsn6q7Q8g+maBwUN1qM29FYNqyB8jXMtw9L1JjBTyRlbKRgpgus+9EDlxDkCI1oQASNxm2K3gn4KUMh2LYGzXSW4GigtRU1sejw6UIX8+G8n8PlOBGXcuR61Y/Wg6gEtkzv8wYMkcOv/h2Yv3MojTWy1XLSAQ2OKddCgbcj4gdh94blWJCozA0lS0v0lDtk/9Ke9KuBvdxbPS81t7v5Y0eYyr5pYiSZKcP2AxxW3vlhHWcd3Mw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: kwolf@xxxxxxxxxx, hreitz@xxxxxxxxxx, mst@xxxxxxxxxx, imammedo@xxxxxxxxxx, anisinha@xxxxxxxxxx, gengdongjiu1@xxxxxxxxx, peter.maydell@xxxxxxxxxx, alistair@xxxxxxxxxxxxx, edgar.iglesias@xxxxxxxxx, npiggin@xxxxxxxxx, harshpb@xxxxxxxxxxxxx, palmer@xxxxxxxxxxx, liwei1518@xxxxxxxxx, dbarboza@xxxxxxxxxxxxxxxx, zhiwei_liu@xxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, anthony@xxxxxxxxxxxxxx, paul@xxxxxxx, berrange@xxxxxxxxxx, peterx@xxxxxxxxxx, farosas@xxxxxxx, eblake@xxxxxxxxxx, vsementsov@xxxxxxxxxxxxxx, eduardo@xxxxxxxxxxx, marcel.apfelbaum@xxxxxxxxx, philmd@xxxxxxxxxx, wangyanan55@xxxxxxxxxx, zhao1.liu@xxxxxxxxx, qemu-block@xxxxxxxxxx, qemu-arm@xxxxxxxxxx, qemu-ppc@xxxxxxxxxx, qemu-riscv@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 19 Nov 2025 13:22:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/11/2025 1:08 pm, Markus Armbruster wrote:
> diff --git a/hw/xen/xen-pvh-common.c b/hw/xen/xen-pvh-common.c
> index b93ff80c85..3e62ec09d0 100644
> --- a/hw/xen/xen-pvh-common.c
> +++ b/hw/xen/xen-pvh-common.c
> @@ -101,7 +101,7 @@ static void
> xen_create_virtio_mmio_devices(XenPVHMachineState *s)
> #ifdef CONFIG_TPM
> static void xen_enable_tpm(XenPVHMachineState *s)
> {
> - Error *errp = NULL;
> + Error *err = NULL;
> DeviceState *dev;
> SysBusDevice *busdev;
>
> @@ -111,8 +111,15 @@ static void xen_enable_tpm(XenPVHMachineState *s)
> return;
> }
> dev = qdev_new(TYPE_TPM_TIS_SYSBUS);
> - object_property_set_link(OBJECT(dev), "tpmdev", OBJECT(be), &errp);
> - object_property_set_str(OBJECT(dev), "tpmdev", be->id, &errp);
> + /*
> + * FIXME This use of &err is is wrong. If both calls fail, the
> + * second will trip error_setv()'s assertion. If just one call
> + * fails, we leak an Error object. Setting the same property
> + * twice (first to a QOM path, then to an ID string) is almost
> + * certainly wrong, too.
> + */
> + object_property_set_link(OBJECT(dev), "tpmdev", OBJECT(be), &err);
> + object_property_set_str(OBJECT(dev), "tpmdev", be->id, &err);
To your question, I don't know the answer, but I think it's far more
likely that the original author didn't grok the proper use of &errp,
than for this behaviour to be intentional.
Surely we just want a failure path and abort the construction if this
goes wrong?
~Andrew
|
