[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/5] nbd/client-connection: Replace error_propagate() by assignment
- To: qemu-devel@xxxxxxxxxx
- From: Markus Armbruster <armbru@xxxxxxxxxx>
- Date: Wed, 19 Nov 2025 14:08:53 +0100
- Cc: kwolf@xxxxxxxxxx, hreitz@xxxxxxxxxx, mst@xxxxxxxxxx, imammedo@xxxxxxxxxx, anisinha@xxxxxxxxxx, gengdongjiu1@xxxxxxxxx, peter.maydell@xxxxxxxxxx, alistair@xxxxxxxxxxxxx, edgar.iglesias@xxxxxxxxx, npiggin@xxxxxxxxx, harshpb@xxxxxxxxxxxxx, palmer@xxxxxxxxxxx, liwei1518@xxxxxxxxx, dbarboza@xxxxxxxxxxxxxxxx, zhiwei_liu@xxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, anthony@xxxxxxxxxxxxxx, paul@xxxxxxx, berrange@xxxxxxxxxx, peterx@xxxxxxxxxx, farosas@xxxxxxx, eblake@xxxxxxxxxx, vsementsov@xxxxxxxxxxxxxx, eduardo@xxxxxxxxxxx, marcel.apfelbaum@xxxxxxxxx, philmd@xxxxxxxxxx, wangyanan55@xxxxxxxxxx, zhao1.liu@xxxxxxxxx, qemu-block@xxxxxxxxxx, qemu-arm@xxxxxxxxxx, qemu-ppc@xxxxxxxxxx, qemu-riscv@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 19 Nov 2025 13:09:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
connect_thread_func() sets a variable to null, then error_propagate()s
an Error * to it. This is a roundabout way to assign the Error * to
it, so replace it by just that.
Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx>
---
nbd/client-connection.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/nbd/client-connection.c b/nbd/client-connection.c
index 79ea97e4cc..6a4f080717 100644
--- a/nbd/client-connection.c
+++ b/nbd/client-connection.c
@@ -207,8 +207,7 @@ static void *connect_thread_func(void *opaque)
qemu_mutex_lock(&conn->mutex);
error_free(conn->err);
- conn->err = NULL;
- error_propagate(&conn->err, local_err);
+ conn->err = local_err;
if (ret < 0) {
object_unref(OBJECT(conn->sioc));
--
2.49.0
|