Re: [PATCH 2/2] amd/iommu: Remove dead non-atomic update checking

["Teddy Astie" <teddy.astie@xxxxxxxxxx>]

Le 13/11/2025 à 12:39, Jan Beulich a écrit :
> On 12.11.2025 16:37, Teddy Astie wrote:
>> When updating a DTE, amd_iommu_setup_domain_device() would check if
>> the update had been non-atomic (i.e rc > 0) and throw a warning if
>> such non-atomic update could be dangerous.  However since commit
>> 3fc44151d83d, rc can no longer be positive, making this branch
>> unreachable code.
>
> I.e. it addresses a Misra concern and hence ...
>
>> No functional change intended.
>>
>> Signed-off-by: Teddy Astie <teddy.astie@xxxxxxxxxx>
>
> ... wants at least an Amends: tag, likely a Fixes: one. Then:

With :

Fixes: 3fc44151d83d ("x86/iommu: remove non-CX16 logic from DMA remapping")

?

As it is the commit that removed the rc > 0 case.

> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Jan
>



--
Teddy Astie | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech