[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] arm/mpu: Implement ioremap_attr for MPU
- To: Harry Ramsey <harry.ramsey@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Wed, 19 Nov 2025 09:00:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/pnjg58ED52tQYY4R8dFccSNs/F3BvlCXEtxSOFEnWA=; b=zCOqKpQv/diU/ncsheywEMgb27+zmHqiHKvuMIP3yErTThRrjvRLLV7/y5PdljaDc10DipWSCaKZaV4I5Le9ndztjwYUngV0Hk+xemIWnnyYD2RTSLL4wQMqSzxTSjzMhXoTCBXSfvMNgOqMblFO4xMFbC5NUBpjadd3wmaFlJWqVEWS4lGdD/N1tvHt+XaaRairbsavtbjJDf3ficFIBjpv2wEEleROPeysE2clAvAj3k4GsIKt5pGwhCLRoGph+zRPTM536+c2AalY8Wsb8M75TKhJo4EkyOJVOqDiyKVTXEAm8Iix/5RAfeue3TZGpeu1eZpe4Nkd9hU1oH31qA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EKC9ScUUWAbgUDrIT7IJDgTEubK+UhSzSKV34k0v4+GN38k7dI7EUG8Fo7zDFMYppiQbTnEJE4lHvnIkyvILqwMP0qvZx7B9LJLwNUxXmuabDxPq98oIpmmpx5FVNFFXLPgttAhG2p/zRmP16oocQhzjqakBQxyQutFrWHRAHyNnaJFur2MIJGF8rsQiC26Hwrc3A1+WIKJGUtBaGK+SYIrQ2akT2Jxtk1K6tikUOtZHJoRr3MsPFGvdHQr8I+nI52bMvera92oER574NHa8Qf9561SeQHogQMYWR0/G2mlXsGSVUSHtkbZfqhBbxxkHz/4ND/otj3mxtDV5uVgFsw==
- Cc: <Luca.Fancellu@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 19 Nov 2025 08:00:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/11/2025 08:53, Harry Ramsey wrote:
> Implement the function `ioremap_attr` for MPU systems.
>
> Signed-off-by: Harry Ramsey <harry.ramsey@xxxxxxx>
> Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
> xen/arch/arm/mpu/mm.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/mpu/mm.c b/xen/arch/arm/mpu/mm.c
> index 29dd8c4622..f25560d746 100644
> --- a/xen/arch/arm/mpu/mm.c
> +++ b/xen/arch/arm/mpu/mm.c
> @@ -473,8 +473,13 @@ void free_init_memory(void)
>
> void __iomem *ioremap_attr(paddr_t start, size_t len, unsigned int flags)
> {
> - BUG_ON("unimplemented");
> - return NULL;
> + paddr_t start_pg = round_pgdown(start);
> + paddr_t end_pg = round_pgup(start_pg + len);
NIT (can be done on commit): There should be a space between initializers and
rest of code. I missed that previously.
~Michal
> + if ( xen_mpumap_update(start_pg, end_pg, flags) )
> + return NULL;
> +
> + /* Mapped or already mapped */
> + return maddr_to_virt(start_pg);
> }
>
> /*
|
