[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 7/7] xen/vm_event: consolidate CONFIG_VM_EVENT
- To: Jan Beulich <jbeulich@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Tue, 18 Nov 2025 18:49:09 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nzs4L2+7DWg036yKvPvtOIUyaPcX4D0qZksOlz0ZG4E=; b=TIC91LLaX80TxpEysCRghya29sCi5HYZxCf3PF9UVOjBx3fJwYJtdJXEHOS8Mza17hlH+UtBibwK9cKItHwOfOxEGwjDdoaIYAMjG6k5zxUmPX6EXjP2xOzzCrqXfeZDvTNlYGaNn+zOfgzYMjKWs3rpGUVR5UX6J8YpVtPTGe8ZsmwJXW4wUIpEnNeQpnBBB8UgyXPi+Se+zKRNo4I1+1oMW3USq9r9+qhuGM4jokPyB2AGDN+9WOAEeD2gKTWGQvr1uMchdsqb2YggR8B5iQcc+aNj55K7+tFZTpgK0YE2WW4CeMjWdrQdRjxZZHgsqsY/5dTtW3lk6NEMML7MkQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=THlU1B/49kY+dx0T7Xm9IoBXWMX3OuEsofYrV+4m7HzQ8lUoNKc/4CSjBPKeLVk07NfCN9W6LksuBoM9USndvFU7qsDCQwkVhJS8/FEORDCTMtI8muvVGFW4/EWAKBl++2YHXTkEhMSB4tucG/dite6yW/XWn3nxmuTQE0C4SEVvNRRcPqFPJxDqFh6JzRFqeAZqh44ZiEsGM/n58FHdWg3EgHk0/eIsOT/0zCwYbmqF0PXARRccVA1RZGxz6TuecH5fE+lKvKgXWE2RQfpk3R8EpI6vE6SKrmO0+blXC29vPTc9ECXCDTpU0H458TSdCS6PLxVmtWC/tZsglVz3yQ==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Tamas K Lengyel" <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Grygorii Strashko <grygorii_strashko@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 19 Nov 2025 00:25:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-11-13 05:16, Jan Beulich wrote:
On 13.11.2025 04:16, Penny Zheng wrote:
File hvm/vm_event.c and x86/vm_event.c are the extend to vm_event handling
routines, and its compilation shall be guarded by CONFIG_VM_EVENT too.
Although CONFIG_VM_EVENT is right now forcibly enabled on x86 via
MEM_ACCESS_ALWAYS_ON, we could disable it through disabling
CONFIG_MGMT_HYPERCALLS later. So we remove MEM_ACCESS_ALWAYS_ON and
make VM_EVENT=y on default only on x86 to retain the same.
The following functions are developed on the basis of vm event framework, or
only invoked by vm_event.c, so they all shall be wrapped with CONFIG_VM_EVENT
(otherwise they will become unreachable and
violate Misra rule 2.1 when VM_EVENT=n):
- hvm_toggle_singlestep
- hvm_fast_singlestep
- hvm_emulate_one_vm_event
-
hvmemul_write{,cmpxchg,rep_ins,rep_outs,rep_movs,rep_stos,read_io,write_io}_discard
And Function vm_event_check_ring() needs stub to pass compilation when
VM_EVENT=n.
Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
---
v1 -> v2:
- split out XSM changes
Isn't that split out patch also needed as a prereq to the one here? The one
here on its own:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
|