[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86emul: replace custom handling for SHLD/SHRD
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 17 Nov 2025 18:10:57 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vwmWbBDu5+zyY602Bfbxmx109B9kwFEAij1oVSKnrzE=; b=keNfWw/Kw2FwQJyuPZviGeTDxBcuJcLEgwYJ5bh5LZARxcwgQJtxyCJcpXbdU9nTLPWhWahJLViuSz+zTTiyfqerdHtfsNVWy8KDERM/Ig3g7IbaVcv1Pd4FaofoiPhYDWOCFA7HVVykjsttPj0x3hRkvaazpXmo9cRPssQxLrDze+XbsJQAArmVjiIYa80j1F/OuvjnyoKXbz2UInGgAgyQS7A68OvKufdcUwlFKZKUeCaAW2ajVT1THoTTBWffyNIoqVRXrkw/yRCnWVruI3Y9MjkAB4AJ04td3nMr+H69LgAlDRRNBAfjP0nL1XnKBX4AfneULUcq1jKVpHKrzQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=U6z1/GCd69nZCpUbRNXHxOCzX1XyDz09Qa5DXNHotTfcX8D5+d7v0pmha52sI7TaLb/u6P/9hsYsgeH6hVUfENp+5+8/mMS+1mXczUdwuXGvSTEr+yPfWB/h9OCSFP+54L9Hq2xLvjN8E5fKfgIkSuXikIy5y3eHtJOmo/S3r2OYC9+L23GbCq0DyMSxkZ/D2W7xmJlk2f668NsJijdeMwN3gKfT7cyp8TMJODcVDEry8tFRnmGPaxz/5rBSq05PThXDNI+I8YG7pcLXZ7bohblq4CdEBKMXv2m0TJUyC1s8vV7RRJiHeErbT18tlxrFYFsiAOlNn6LZ3ey0ZVEUOg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 17 Nov 2025 18:11:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/07/2025 3:24 pm, Jan Beulich wrote:
> Use an existing macro instead of open-coding the operation and flags
> handling, just like we already do in x86_emul_rmw(). While possibly
> yielding slightly larger compiled code, it's easier to maintain this
> way.
>
> Note that the setting of dst.orig_val was already redundant with that
> done ahead of the main switch() (where DST_MEM is handled), the latest
> as of 4e59f578cb75 ("x86emul: simplify SHLD/SHRD handling").
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
