[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 0/4] Implement CPU hotplug on Arm


  • To: Julien Grall <julien@xxxxxxx>, Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
  • Date: Thu, 25 Sep 2025 11:45:54 +0300
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=16u00z1+mtyVpnPty5YPkHMzdWoFNdqBIY/vClrtpuY=; b=k9I22jU5hYAVpSMFsToKC96pA4hHc8w4/cijhkKqeYFTVBeIzLXrRaAH8OwvZG5hstU+ncZz5hYIj8F7gHgjuEaR304mF2GzEgwc6pTGEAkSRt0QIDfBsfb0luE0NVzlpF7Ld2ZJptXYcPTnn7bXohyAeV2cxGyRTrYN2sjm+78rWfGNXWHQWPvu9kJQvfiih4+FSGfK7tlWtXPfHliU2toetEycdS1oFWR774YxZFx6+e1KthDDnAGEuuhylj5Xu68LcsnG82OfAvGaelXcxIoluXxaQF/ItiaS7XnNWqNjpBe+Orff2qhG2hirPT+ZcGibl5OOxT7CV1Iz1GbMow==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j6OIItD6Z0+40cCSnwG5N/LQLnVcERzzgvzyO5556EeKWkhGfQlV+SUmbd6Z5fVWYpXQc7x1QGEobMNeAtoM4YgoItKK7X5frnATXLuwmq9MVbu7fYvPpGqlbbTUAi3bUz0xQvTnA8zvKMHgnaFK+Boy+yY/tueXnzcaiNe+/oImxZxH6hqrraN7yCo4X4v7QdYqx7+9T6Crz7/99QdcF9rCG4n/Vmf2R3Rpg+9huhUkVYJf78hes2EzLcHro4xjhUqQpaS4M1bzS3wrb/dOhaQSOVfYi0mtPuwQ2VlKoUd4n9nJja4pNXWazAt+MYs0dTxXUZ5X4bZKr26ACHQSkw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Thu, 25 Sep 2025 08:46:24 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>



On 23.09.25 21:38, Julien Grall wrote:
Hi Grygorii,

On 23/09/2025 17:09, Grygorii Strashko wrote:
On 18.09.25 15:16, Mykyta Poturai wrote:
This series implements support for CPU hotplug/unplug on Arm. To achieve this,
several things need to be done:

1. XEN_SYSCTL_CPU_HOTPLUG_* calls implemented.
2. timer and GIC maintenance interrupts switched to static irqactions to remove
the need for freeing them during release_irq.
3. Enabled the build of xen-hptool on Arm.

Tested on QEMU.

Mykyta Poturai (4):
   arm/time: Use static irqaction
   arm/gic: Use static irqaction
   arm/sysctl: Implement cpu hotplug ops
   tools: Allow building xen-hptool without CONFIG_MIGRATE

  config/arm64.mk                  |  1 +
  config/x86_32.mk                 |  1 +
  config/x86_64.mk                 |  1 +
  tools/libs/guest/Makefile.common |  4 +-
  tools/misc/Makefile              |  2 +-
  xen/arch/arm/gic.c               | 10 ++++-
  xen/arch/arm/sysctl.c            | 67 ++++++++++++++++++++++++++++++++
  xen/arch/arm/time.c              | 20 ++++++++--
  8 files changed, 98 insertions(+), 8 deletions(-)


Hence you introducing new feature for ARM I'd very much appreciated if you
add corresponding documentation under docs/hypervisor-guide/arm/.

I think some documentation is good. But why does this need to be Arm specific?

Only because this series is for ARM, if it could be generic (at least 
partially) - even better.


--
Best regards,
-grygorii




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.