[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 16/26] xen/domctl: wrap arch-specific domain_set_time_offset() with CONFIG_MGMT_HYPERCALLS
- To: Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Thu, 25 Sep 2025 08:01:10 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lf4IFhFuD8Di93RYEIE05Acw8s3Dm4KQr/5bJzi0AZA=; b=WebUqCwiV5K58QR7XwErtQkNmB2YQKgxDIkEvVvpf/6I5ajR2Q9PDHyWvxm/lDP0I84L7hbwkSJoKJ0+Jc30FpTMAkr2TNVyZia1cKKYwgtEdVjeEo+jr7VhsDvXE3TRXgYTP+r3Dfhu4avaUfgGA5bjR3aNiX2J/K5ptNQIyMYdSmxIvYAKDUte3R75OAJG7WlHN7iT94fI9WASGy2GYrlCdJ7ju6tBwC0m3qpfn+Z76ls6AC+EdPSYuenjrShXkQQV/NMMUIsjnfOsqjgjWsc2/OhsxLR9mpXiBA5OXK3t805g3srA47I646oS7qd2zqfyrP3mpY2hQzpu+uAisw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k2/jEchnOAv+g7rYOJG45sBSi9p2QqgzgRE9M3kHSzeVJtLLsnPkL8KWQfzAkm/nxglmNWAPmx1p3Cxy/lrGIY44jLklZ/iFPMTmY4ScmY/sWbjpsQGrGVxCr1ULnojfJyJdGcGGYtfoLwdLBj0tRO+ljNvD/xHmTvTJCv/Ia376kTLYbJ7WzSPNMFr57Yj8KAp6Q8wpQSXJW5gPfP+Hv55JwIa/rMyTwqvR2LjY2LsXPTeB52Ic493m5eebp6pTfYohnw0dqu/lhJZbesE+y67nrbjzZY68d09bXnQgeqbdWg8ycZdUlOYIkpSXQ2ylbwxpQNF5zMAZpOzH+uhSrQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 25 Sep 2025 08:01:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-09-25T07:57:28.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHcIiYVha7/RUmVzU62kcSZyqSE7LSN2dWAgBXF6hA=
- Thread-topic: [PATCH v2 16/26] xen/domctl: wrap arch-specific domain_set_time_offset() with CONFIG_MGMT_HYPERCALLS
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, September 11, 2025 7:28 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Julien Grall <julien@xxxxxxx>; Bertrand
> Marquis <bertrand.marquis@xxxxxxx>; Orzel, Michal <Michal.Orzel@xxxxxxx>;
> Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Anthony PERARD <anthony.perard@xxxxxxxxxx>;
> Roger Pau Monné <roger.pau@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 16/26] xen/domctl: wrap arch-specific
> domain_set_time_offset() with CONFIG_MGMT_HYPERCALLS
>
> On 10.09.2025 09:38, Penny Zheng wrote:
> > Arch-specific domain_set_time_offset() is responisble for
> > XEN_DOMCTL_settimeoffset domctl-op, and shall be wrapped with
> > CONFIG_MGMT_HYPERCALLS Wrap XEN_DOMCTL_settimeoffset-case
> transiently
> > with CONFIG_MGMT_HYPERCALLS, and it will be removed when introducing
> > CONFIG_MGMT_HYPERCALLS on the common/domctl.c in the last.
>
> As I keep seeing this same wording, I finally have to say something there as
> well: For one, the last patch doesn't introduce CONFIG_MGMT_HYPERCALLS on
> common/domctl.c. In instead makes the building of common/domctl.o conditional
> upon that control being set. And then, "in the last" (btw - last what?) is as
> unhelpful
> as "in the next patch" or "in the previous patch". When writing commit
> messages,
> you want to make sure they make sense all on their own, no matter in what
> order
> patches are committed (in particular possibly piecemeal and interspersed with
> other
> patches). Possible replacement wording:
>
Thanks for the detailed clarification! Learned and will fix
>
> Jan
|
