[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 4/4] tools: Allow building xen-hptool without CONFIG_MIGRATE
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
- Date: Tue, 23 Sep 2025 13:19:38 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EiyiYclPvxXuCdt4j8G3TCLnJRhWWiPszQ8is/PTa54=; b=YV1Rag6DfFxfXj5evb/+Iw8YYQsB74yJmdkoerHICLQUDpMTIdjWp9e1qajDr/JaMCJgx8imrrxn6ucXvKuITEZ8Wu7BBwEsKI8u9BP0MGjTtMELQgxsV6KDBICQqe33fq4E+gdlTqmAwGJbiYb8jd0plqNFMuMc4iHgXBWV5qwX347yLfaWARJP5Y3KdlEpZDsQ/cua9YrP3fv+9N7RxTm/wc7RASuOfFz6en3+uUbflmijo0BytnnZpUEL5JWdYjt2CiM0zf1XSAnzm88Uo6N6CXAYeK0plV3z2vpHLAFLmNiLsH4m0+MXyM1JpeZkBaq0POZr5YwrmtH7Aji7cg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UjAo23NzGev5Ab2JJnhHqF0W05quE4sHRKH9i7kjxeU0Exh9vCwC4fpWoObmvw1jFRQG2PqjA5u6MZDRtxiaBRAwIWB3fMThZjo4eFIfJZRDSPfN9h72QNRoKd+vGiaqTo5B9Q7GAAH20WsgFceQajQjBeuLvLshoNWFjIlHE5YAp5XPIhS3qxX++l3qZPzHpw1uash5fwxGDVAAkNfkKi1SQZZAK5IP+lx/pdIyRbY98a9s14VFaec6LQH+sYgZTpdAVTQ5aa+OZMdDx46ZWceiKCE2XP0MgacunyuCxVGphvXKX3SESiuWh/sWQbK6qk4vgJlz5bzDgj6R0148gA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 23 Sep 2025 13:19:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcKJYT9WcJIkqhZk6dQ6fXEj6SxLSZCGOAgAe/3QA=
- Thread-topic: [PATCH v1 4/4] tools: Allow building xen-hptool without CONFIG_MIGRATE
On 18.09.25 17:59, Jan Beulich wrote:
> On 18.09.2025 14:16, Mykyta Poturai wrote:
>> --- a/config/arm64.mk
>> +++ b/config/arm64.mk
>> @@ -1,5 +1,6 @@
>> CONFIG_ARM := y
>> CONFIG_ARM_64 := y
>> +CONFIG_HOTPLUG := y
>>
>> CONFIG_XEN_INSTALL_SUFFIX :=
>>
>> --- a/config/x86_32.mk
>> +++ b/config/x86_32.mk
>> @@ -3,6 +3,7 @@ CONFIG_X86_32 := y
>>
>> CONFIG_MIGRATE := y
>> CONFIG_XCUTILS := y
>> +CONFIG_HOTPLUG := y
>>
>> CFLAGS += -m32 -march=i686
>>
>> --- a/config/x86_64.mk
>> +++ b/config/x86_64.mk
>> @@ -3,6 +3,7 @@ CONFIG_X86_64 := y
>>
>> CONFIG_MIGRATE := y
>> CONFIG_XCUTILS := y
>> +CONFIG_HOTPLUG := y
>>
>> CONFIG_XEN_INSTALL_SUFFIX := .gz
>
> I realize you only do what is already being done, but I question this
> way of doing things when the scope is tools-only. Any CONFIG_* put here
> cannot have an identically named, but potentially set differently
> Kconfig setting in xen/: Any use of such in a Makefile could end up being
> wrong, and would pretty surely end up being confusing.
>
> Jan
I have checked the whole codebase and didn't find any other
CONFIG_HOTPLUG, the only similar thing is CONFIG_HOTPLUG_CPU. Anyway, I
can change it to something more specific like CONFIG_HPTOOL for example.
--
Mykyta
|
