Re: [PATCH] x86/domain: Dump domain paging pool sizes with the rest of the pageframe info

[Aidan Allen <aidan.allen1@xxxxxxxxx>]

On Thu, Jul 24, 2025 at 12:52 PM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 24.07.2025 13:40, Aidan Allen wrote:
> > --- a/xen/arch/x86/domain.c
> > +++ b/xen/arch/x86/domain.c
> > @@ -253,6 +253,10 @@ void dump_pageframe_info(struct domain *d)
> >                 page->count_info, page->u.inuse.type_info);
> >      }
> >
> > +    printk("    Domain paging pool: total: %d, free: %d, p2m: %d\n",
> > +           d->arch.paging.total_pages, d->arch.paging.free_pages,
> > +           d->arch.paging.p2m_pages);
>
> Should this perhaps be gated, to avoid printing all zeroes for domains not
> using an paging mode? Whether to use paging_mode_enabled() to do so I'm not
> sure, as a domain with no paging mode enabled could still have a paging
> pool configured.
>

Hi Jan,
I can gate this on total_pages > 0 if that would address your concern
with paging_mode_enabled().

However, regarding the gating itself, I don't believe that the line
saved by not printing this
is worth the potential confusion of somebody looking for this
information and not finding
it, I would prefer to leave it printing all zeroes.

Best, Aidan.