[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v2 1/2] xen/evtchn: enable build optimization for evtchn_move_pirqs()/send_guest_pirq()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
- Date: Tue, 22 Jul 2025 16:46:00 +0300
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I0IHKCwgZNtKFki9yhPYWZGCcxCDgwbmSTApxsomuec=; b=nP27kiIFT4gYkdDwJjVvayS+fTdq0yao5Q2JaLEfu3eIpJxt+DQS6JElCIejUxQ30tK80OWSkrpLpoXPWcYtBgtSZBHNvfOc0zHqcrZAiybsrBUbBtSlGdaPBDds5oP0TfFd8xismTJGD7rCOpDckAup0HghTCZHDWGe2Wo8qQW2i8YKA35FYBu8L0VHQHI78ORJGrGzf4SmFizfIoOqRhg4PX2lbZfsa3Qr0ldiNgR7iG0AUlTthxiYc91uOHXM44Dvca7wI9Zu1vM/UX8LNI/fubS2brgmsVm0QKDcwgNWDuUO32Nw5ZNroyrahwrlT+QhRYS6zb7PUGLm28V5pQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Fjk1NYiwX7v/QJFqWS/Mo+n9w3AJcGqwjXUsUAgA49yYWhXzJKZPSYlZSq84/bEKXBay3nRb87U4r3p2+ibev+alzamSFrEzZPiql4b5XSyMXh04d3hHDyTGpRZUTNDEimjlRSW20zIkzA09sRTbK23aq2FirsLjJ8A4KFMmWF0zSHP34yGu+nwBlHYvzGKmX90XFOK4JFPGNUi/PWdE/Rc7PU7hCIJiV72rgynvNJMPaM0dZd4+NIVwUkMts1yD8Lw8voU72DWBm7HlNirHf4y0LhTMmRRD5VQt5A0dL0AjPu3t+GrULgrMbwj1az0uisVbA8sWgKM7bUNRfQyvUA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Ayan Kumar Halder <ayankuma@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 22 Jul 2025 13:46:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.07.25 11:23, Jan Beulich wrote:
On 18.07.2025 12:11, Grygorii Strashko wrote:
From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
On platforms without PIRQ support evtchn_move_pirqs()/send_guest_pirq()
functions are unreachable (Misra rule 2.1).
Move these function under CONFIG_HAS_PIRQ ifdefs to fix Misra rule 2.1
violation and resolve call of evtchn_move_pirqs() from common /sched/core.c
vcpu_move_irqs() code by moving evtchn_move_pirqs() into x86
arch_move_irqs() callback (which is converted to define).
The patch title isn't quite appropriate anymore with this description, I
think.
Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
preferably with ...
@@ -1707,6 +1709,7 @@ void evtchn_destroy_final(struct domain *d)
}
+#ifdef CONFIG_HAS_PIRQ
void evtchn_move_pirqs(struct vcpu *v)
{
struct domain *d = v->domain;
... one of the two blank lines also dropped here, just like you do ...
@@ -1722,7 +1725,7 @@ void evtchn_move_pirqs(struct vcpu *v)
}
read_unlock(&d->event_lock);
}
-
+#endif /* CONFIG_HAS_PIRQ */
... here. Happy to adjust while committing,
Thank you.
but please consider suggesting a replacement patch title.
Honestly, I, by myself, not sure about proper patch title :(
My options would be:
"xen/evtchn: evtchn_move_pirqs()/send_guest_pirq() fix MISRA Rule 2.1
violation"
"xen/evtchn: opt out of common pIRQ code for arches without pIRQ support"
"xen/evtchn: fully restrict concept of pIRQ for arches with pIRQ support only"
--
Best regards,
-grygorii
|
