[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/10] dom0less: Reinitialise all variables on each loop iteration
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Date: Tue, 22 Jul 2025 15:31:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qh0tJeGUWSR+R8OyP4NO55PQUHqjeCSZBj19WYOysWA=; b=UH/GHpQsUdcJ5C/IlPhmodjGdnn08WrkYUy5zM/miWlZxDwc9ZEF1F2hyZXbhbYl/AWcQuHFK8765pR7TXISxLKQ2lWPO75q54V0mb+uhQHyo0MXMp+PbMRDN9JuVmKz3Knt+GtTQylrC38hOrd56VozGmGqXvVz9LQtcUuCBsFfYMPaCn1t7HuhJS5TobOQz+NruY6p7Z/bXWAeXJ4HVMyqDDgU/m/vJDtfJMAe4xtleR34oaiVzkYfsv0ZNSxdyiZ172rUqyioZgOfiZPw7XLd+3nGfLwIMqcuC2qskN4KYr4W3CU1AM853kknt09vOB/vZqR5B7reRuUyQkzGdA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HGQWoPo5NgxHT4zUv9dnsNjUe2KFdYTX5oDJoh8h/O/NkoJ9gpukWBHCQW0d/E/xz1YowqSLCB9XdS4adUrYvTneyHdxARNW4heFA28is9U95JtRUSbNA9vK+ohxoczzCYYIiLAbLemC8lWgVRKhPsJ+1J2aaj2Ni6Hu8zvGuzlSrX325SJ9HvXF8nLDfOp2LPYdQ+q3fBy5CedCLxNWd2PZMCtmYKDANkYHhNRr4mOpN+NYfbDZDuIGr9E8wzeJZshjXsxHVPnbdLULZ5eVRNs2+68FHs5Lc1VVtem0MhqGM4afcFvJKxdjh72dR+MHtcp8Z7nLc0MFW1bAm4g4Lg==
- Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 22 Jul 2025 13:31:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue Jul 22, 2025 at 2:57 PM CEST, Jan Beulich wrote:
> On 22.07.2025 14:37, Alejandro Vallejo wrote:
>> On Tue Jul 22, 2025 at 2:18 PM CEST, Jan Beulich wrote:
>>> On 22.07.2025 13:59, Alejandro Vallejo wrote:
>>>> Reduce the scope of every variable so they are reinitialised. "iommu",
>>>> for instance, isn't being cleared, so the wrong flags may make it to
>>>> domains that should not have them.
>>>
>>> Yet "for instance" isn't quite right, is it? "iommu" is the only one where
>>> the (re)init was misplaced. The other two ...
>>
>> We do strive for minimal scope where possible. But you're right "for
>> instance"
>> might be misleading in suggesting there's more bugs than one.
>>
>> I'm happy to have "for instance" removed, leaving the rest as-is, if that
>> works
>> for you.
>
> Except that "every" isn't quite right either. Nor is "they".
>
> Jan
Ok, take 3:
Reduce the scope of dom0less_iommu, iommu and cpupool_node. iommu, in
particular, wasn't being cleared, so the wrong flags may make it to
domains that should not have them.
Cheers,
Alejandro
|
