[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/10] static-evtchn: Add missing include


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
  • Date: Tue, 22 Jul 2025 14:41:43 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0tF5B9pkxKd/SgClD2znYOMAnQvtUBzHNwKlsy+Py5E=; b=yt6A9I2/PVDvCU66jXitRm3cWD4dJ3/WKnjgyRFxSBsgGsiw2vtJYSz1w5SxfxboIPmK3ssPIxvQwatfDdZBG9ke+PIdxtedIFg3K1q6TCQraHT9XdDieVNzMQz1m8+07LLHmuAdFqoT/4BmIXqmupQZwCC0qgbkWNS8XV0kCFUgS1uCEJQF4mFn1ViddI7g/l7HSxAgG9unI4wmV0aATM3K1NiwPoJutZ625r8WHTnmcI2H50otmVsbdtfgCLSi8cBCoEUVMGh4LeH4KDg2ZQd+OnsQ7MykHLiNpaa3Q/DFM5Iq/4cKjQzFK7JRcFhyIk5rlEdGVZr+obQLzQNFVw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oMljxlQ1roKCuQOrmcjMtz7ftXbRUh18Rs7oYS/HRnO0phaVaErifOS/c47e9CXVJuGho/pON6gBoIUJR4P83GSurPVnDawzqTBqjhJ3uXy7S7UOVEP1UJgktZnwiRo8lBk/goP22kiaE2vV90lsvYFX3F4zZlKgreUAXPiHxBp2rQhukYFFFuq8jUd03wE8x26lJC8tnlDpeyzRhfmEf6XxHMHlk5kZu/I0VUBzQujafcaN+mYRCKa+zjhytdwHOmTMwoJEiukmu/U3JB78u/0IFChUjJzdI2ujWESeFPbU858GT5Qh35NbIpzZjg9++/Gb9Xl/11Frxq0ajB2NDg==
  • Cc: Alejandro Vallejo <agarciav@xxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 22 Jul 2025 12:42:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue Jul 22, 2025 at 2:10 PM CEST, Jan Beulich wrote:
> On 22.07.2025 13:59, Alejandro Vallejo wrote:
>> From: Alejandro Vallejo <agarciav@xxxxxxx>
>> 
>> When later on x86 starts using this file in later patches it won't find
>> device_tree.h because it's only transitively included by arm.
>> 
>> Make it explicit.
>> 
>> Not a functional change.
>> 
>> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
>> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
>> Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
>
> I'm certainly happy to trust you, but on a v1 submission I'm a little
> surprised to find two tags present already.
>
> Jan

They came out of internal review, and I didn't really want to drop them.

Everyone with tags is in CC, as auto-cc "helpfully" does in the absence of
further arguments (for better or worse), so they can pitch in.

If this is a problem, I'll make a note to drop internal tags before public
submissions in the future, and feel very free to ignore these. I do understand
it's important to keep proper paper trail, which, by doing this, is lost.

Cheers,
Alejandro



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.